✗ Fi.CI.CHECKPATCH: warning for drm/i915: PLL state check stuff (rev2)

[Patchwork <patchwork@xxxxxxxxxxxxxxxxxxxxxx>]

== Series Details ==

Series: drm/i915: PLL state check stuff (rev2)
URL   : https://patchwork.freedesktop.org/series/129735/
State : warning

== Summary ==

Error: dim checkpatch failed
6787bc9cd454 drm/i915: Fix PLL state check for gmch platforms
987dac5d8550 drm/i915: Include the CRTC name in the ELD buffer mismatch
69f42808f533 drm/i915: Reuse ibx_dump_hw_state() for gmch platforms
5c9498f06b0e drm/i915: Add PLL .compare_hw_state() vfunc
-:62: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'name' - possible side-effects?
#62: FILE: drivers/gpu/drm/i915/display/intel_display.c:5050:
+#define PIPE_CONF_CHECK_PLL(name) do { \
+	if (!intel_dpll_compare_hw_state(dev_priv, &current_config->name, \
+					 &pipe_config->name)) { \
+		pipe_config_pll_mismatch(fastset, crtc, __stringify(name), \
+					 &current_config->name, \
+					 &pipe_config->name); \
+		ret = false; \
+	} \
+} while (0)

-:62: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'name' may be better as '(name)' to avoid precedence issues
#62: FILE: drivers/gpu/drm/i915/display/intel_display.c:5050:
+#define PIPE_CONF_CHECK_PLL(name) do { \
+	if (!intel_dpll_compare_hw_state(dev_priv, &current_config->name, \
+					 &pipe_config->name)) { \
+		pipe_config_pll_mismatch(fastset, crtc, __stringify(name), \
+					 &current_config->name, \
+					 &pipe_config->name); \
+		ret = false; \
+	} \
+} while (0)

-:72: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'name' - possible side-effects?
#72: FILE: drivers/gpu/drm/i915/display/intel_display.c:5060:
+#define PIPE_CONF_CHECK_TIMINGS(name) do {     \
 	PIPE_CONF_CHECK_I(name.crtc_hdisplay); \
 	PIPE_CONF_CHECK_I(name.crtc_htotal); \
 	PIPE_CONF_CHECK_I(name.crtc_hblank_start); \

-:333: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#333: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:4552:
+		return i915->display.dpll.mgr->compare_hw_state(a, b);
+	} else {

total: 0 errors, 1 warnings, 3 checks, 308 lines checked
54a518629e96 drm/i915: Enable fastboot across the board