Re: [PATCH v2] drm/i915/selftests: Increasing the sleep time for live_rc6_manual

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hi Anirban

On 2/9/2024 5:41 PM, Sk Anirban wrote:
From: Anirban Sk <sk.anirban@xxxxxxxxx>

Sometimes gt_pm live_rc6_manual selftest fails due to no power being
measured for the rc6 disabled period. Therefore increasing the rc6 disable
period from 250ms to 1000ms to rule out such sporadic failure.

Signed-off-by: Anirban Sk <sk.anirban@xxxxxxxxx>
Reviewed-by: Anshuman Gupta <anshuman.gupta@xxxxxxxxx>

Change log:
Remove the above line. move the version info above signed-off.
v2: add Reviewed-by: Anshuman Gupta
don't have to add this
     More descriptive and improved commit message.
add the name of the person in brackets

"v2 : More descriptive and improved commit message (Anshuman)"

Thanks
Riana Tauro
---
  drivers/gpu/drm/i915/gt/selftest_rc6.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/gt/selftest_rc6.c b/drivers/gpu/drm/i915/gt/selftest_rc6.c
index a7189c2d660c..1aa1446c8fb0 100644
--- a/drivers/gpu/drm/i915/gt/selftest_rc6.c
+++ b/drivers/gpu/drm/i915/gt/selftest_rc6.c
@@ -62,12 +62,12 @@ int live_rc6_manual(void *arg)
dt = ktime_get();
  	rc0_power = librapl_energy_uJ();
-	msleep(250);
+	msleep(1000);
  	rc0_power = librapl_energy_uJ() - rc0_power;
  	dt = ktime_sub(ktime_get(), dt);
  	res[1] = rc6_residency(rc6);
  	if ((res[1] - res[0]) >> 10) {
-		pr_err("RC6 residency increased by %lldus while disabled for 250ms!\n",
+		pr_err("RC6 residency increased by %lldus while disabled for 1000ms!\n",
  		       (res[1] - res[0]) >> 10);
  		err = -EINVAL;
  		goto out_unlock;



[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux