✗ Fi.CI.CHECKPATCH: warning for drm/i915: drm_dbg_kms() conversions and cleanups

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



== Series Details ==

Series: drm/i915: drm_dbg_kms() conversions and cleanups
URL   : https://patchwork.freedesktop.org/series/129677/
State : warning

== Summary ==

Error: dim checkpatch failed
56fa1f3dbdc1 drm/i915: Correct for_each_old_global_obj_in_state() arguments
-:27: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__state' - possible side-effects?
#27: FILE: drivers/gpu/drm/i915/display/intel_global_state.h:40:
+#define for_each_old_global_obj_in_state(__state, obj, old_obj_state, __i) \
 	for ((__i) = 0; \
 	     (__i) < (__state)->num_global_objs && \
 		     ((obj) = (__state)->global_objs[__i].ptr, \
+		      (old_obj_state) = (__state)->global_objs[__i].old_state, 1); \
 	     (__i)++) \
 		for_each_if(obj)

-:27: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'obj' - possible side-effects?
#27: FILE: drivers/gpu/drm/i915/display/intel_global_state.h:40:
+#define for_each_old_global_obj_in_state(__state, obj, old_obj_state, __i) \
 	for ((__i) = 0; \
 	     (__i) < (__state)->num_global_objs && \
 		     ((obj) = (__state)->global_objs[__i].ptr, \
+		      (old_obj_state) = (__state)->global_objs[__i].old_state, 1); \
 	     (__i)++) \
 		for_each_if(obj)

-:27: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i' - possible side-effects?
#27: FILE: drivers/gpu/drm/i915/display/intel_global_state.h:40:
+#define for_each_old_global_obj_in_state(__state, obj, old_obj_state, __i) \
 	for ((__i) = 0; \
 	     (__i) < (__state)->num_global_objs && \
 		     ((obj) = (__state)->global_objs[__i].ptr, \
+		      (old_obj_state) = (__state)->global_objs[__i].old_state, 1); \
 	     (__i)++) \
 		for_each_if(obj)

total: 0 errors, 0 warnings, 3 checks, 13 lines checked
5ba467d12038 drm/i915/sdvo: Convert to per-device debugs
-:65: CHECK:SPACING: spaces preferred around that '+' (ctx:VxV)
#65: FILE: drivers/gpu/drm/i915/display/intel_sdvo.c:523:
+		drm_dbg_kms(&i915->drm, "I2c transfer returned %d/%d\n", ret, i+3);
 		                                                               ^

total: 0 errors, 0 warnings, 1 checks, 366 lines checked
a5926bea86ec drm/i915/sdvo: Fix up code alignment
1359b5df0437 drm/i915/color: Use per-device debugs
73884978ec47 drm/i915/fb: Use per-device debugs
4c98fc3606e9 drm/i915/bios: Switch to kms debugs
869672750516 drm/i915/bios: Use per-device debugs for VBT related stuff
-:153: WARNING:LONG_LINE: line length of 113 exceeds 100 columns
#153: FILE: drivers/gpu/drm/i915/display/intel_bios.c:2147:
+			    "Unsupported I_boost value found in VBT (%d), display may not work properly\n", val);

total: 0 errors, 1 warnings, 0 checks, 277 lines checked
384b6f365380 drm/i915/hdcp: Use per-device debugs
051849bda5f6 drm/i915/wm: Pass the whole i916 to intel_get_cxsr_latency()
b2c0beb9cfca drm/i915/wm: Use per-device debugs in pre-ilk wm code
c3376b352d10 drm/i915/wm: Use per-device debugs ilk wm code
a99cfcd065eb drm/i915/dvo/ns2501: Nuke pointless casts
058ca068062c drm/i915/dvo: Use sizeof(*variable) instead of sizeof(type)





[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux