On Fri, Feb 02, 2024 at 10:48:32AM -0700, Drew Davenport wrote:
> [...]
> > diff --git a/drivers/gpu/drm/i915/display/intel_modeset_setup.c b/drivers/gpu/drm/i915/display/intel_modeset_setup.c
> > index b8f43efb0ab5a..94eece7f63be3 100644
> > --- a/drivers/gpu/drm/i915/display/intel_modeset_setup.c
> > +++ b/drivers/gpu/drm/i915/display/intel_modeset_setup.c
> > @@ -318,6 +318,12 @@ static void intel_modeset_update_connector_atomic_state(struct drm_i915_private
> > const struct intel_crtc_state *crtc_state =
> > to_intel_crtc_state(crtc->base.state);
> >
> > + if (crtc_state->dsc.compression_enable) {
> > + drm_WARN_ON(&i915->drm, !connector->dp.dsc_decompression_aux);
>
> I'm running into this warning on a JSL device that uses a MIPI panel.
>
> Looking at gen11_dsi_dsc_compute_config in icl_dsi.c, I don't see any
> code paths where dsc_compression_aux would be set.
>
> Should there be a check here for the encoder type to avoid setting
> dsc_decompression_enabled for DSI encoders?
Yes thanks for the report, this state should get updated only for DP
connectors, I missed this when adding the above. I think it's better to
do this in a connector specific hook as in:
https://lore.kernel.org/intel-gfx/20240205132631.1588577-1-imre.deak@xxxxxxxxx
Also I wonder if we could add ICL/JSL platforms with DSI (DSC) output to
CI, CC'd the CI team.
> > + connector->dp.dsc_decompression_enabled = true;
> > + } else {
> > + connector->dp.dsc_decompression_enabled = false;
> > + }
> > conn_state->max_bpc = (crtc_state->pipe_bpp ?: 24) / 3;
> > }
> > }
