RE: [PATCH v3 19/21] drm/i915/psr: Update PSR module parameter descriptions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: Hogander, Jouni <jouni.hogander@xxxxxxxxx>
> Sent: Friday, January 19, 2024 3:40 PM
> To: intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> Cc: Manna, Animesh <animesh.manna@xxxxxxxxx>; Hogander, Jouni
> <jouni.hogander@xxxxxxxxx>
> Subject: [PATCH v3 19/21] drm/i915/psr: Update PSR module parameter
> descriptions
> 
> We are re-using PSR module parameters for panel replay. Update module
> parameter descriptions with panel replay information:
> 
> enable_psr:
> 
> -1 (default) == follow what is in VBT
> 0 == disable PSR/PR
> 1 == Allow PSR1 and PR full frame update
> 2 == allow PSR1/PSR2 and PR Selective Update
> 
> enable_psr2_sel_fetch
> 
> 0 == disable selective fetch for PSR and PR
> 1 (default) == allow selective fetch for PSR PR
> 
> Signed-off-by: Jouni Högander <jouni.hogander@xxxxxxxxx>

LGTM.
Reviewed-by: Animesh Manna <animesh.manna@xxxxxxxxx>

> ---
>  drivers/gpu/drm/i915/display/intel_display_params.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display_params.c
> b/drivers/gpu/drm/i915/display/intel_display_params.c
> index 11e03cfb774d..1c5e20ec7f1d 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_params.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_params.c
> @@ -102,7 +102,8 @@ intel_display_param_named_unsafe(enable_fbc, int,
> 0400,
> 
>  intel_display_param_named_unsafe(enable_psr, int, 0400,
>  	"Enable PSR "
> -	"(0=disabled, 1=enable up to PSR1, 2=enable up to PSR2) "
> +	"(0=disabled, 1=enable up to PSR1 and Panel Replay full frame
> update, "
> +	"2=enable up to PSR2 and Panel Replay Selective Update) "
>  	"Default: -1 (use per-chip default)");
> 
>  intel_display_param_named(psr_safest_params, bool, 0400, @@ -112,7
> +113,7 @@ intel_display_param_named(psr_safest_params, bool, 0400,
>  	"Default: 0");
> 
>  intel_display_param_named_unsafe(enable_psr2_sel_fetch, bool, 0400,
> -	"Enable PSR2 selective fetch "
> +	"Enable PSR2 and Panel Replay selective fetch "
>  	"(0=disabled, 1=enabled) "
>  	"Default: 1");
> 
> --
> 2.34.1





[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux