== Series Details == Series: drm/i915/display/vdsc: Fix the macro that calculates DSCC_/DSCA_ PPS reg address URL : https://patchwork.freedesktop.org/series/129389/ State : warning == Summary == Error: dim checkpatch failed c9f9431dd2e4 drm/i915/display/vdsc: Fix the macro that calculates DSCC_/DSCA_ PPS reg address -:7: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?) #7: Patch (bd077259d0a9: drm/i915/vdsc: Add function to read any PPS register) defines -:23: WARNING:COMMIT_LOG_USE_LINK: Unknown link reference 'Bug:', use 'Link:' or 'Closes:' instead #23: Bug: https://gitlab.freedesktop.org/drm/intel/-/issues/10172 -:43: WARNING:LONG_LINE: line length of 129 exceeds 100 columns #43: FILE: drivers/gpu/drm/i915/display/intel_vdsc_regs.h:54: +#define DSCA_PPS(pps) ((pps < 12) ? _MMIO(_DSCA_PPS_0 + (pps) * 4):_MMIO(_DSCA_PPS_0 + (pps + 12) * 4)) -:43: CHECK:SPACING: spaces required around that ':' (ctx:VxV) #43: FILE: drivers/gpu/drm/i915/display/intel_vdsc_regs.h:54: +#define DSCA_PPS(pps) ((pps < 12) ? _MMIO(_DSCA_PPS_0 + (pps) * 4):_MMIO(_DSCA_PPS_0 + (pps + 12) * 4)) ^ -:43: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pps' - possible side-effects? #43: FILE: drivers/gpu/drm/i915/display/intel_vdsc_regs.h:54: +#define DSCA_PPS(pps) ((pps < 12) ? _MMIO(_DSCA_PPS_0 + (pps) * 4):_MMIO(_DSCA_PPS_0 + (pps + 12) * 4)) -:43: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'pps' may be better as '(pps)' to avoid precedence issues #43: FILE: drivers/gpu/drm/i915/display/intel_vdsc_regs.h:54: +#define DSCA_PPS(pps) ((pps < 12) ? _MMIO(_DSCA_PPS_0 + (pps) * 4):_MMIO(_DSCA_PPS_0 + (pps + 12) * 4)) -:44: WARNING:LONG_LINE: line length of 129 exceeds 100 columns #44: FILE: drivers/gpu/drm/i915/display/intel_vdsc_regs.h:55: +#define DSCC_PPS(pps) ((pps < 12) ? _MMIO(_DSCC_PPS_0 + (pps) * 4):_MMIO(_DSCC_PPS_0 + (pps + 12) * 4)) -:44: CHECK:SPACING: spaces required around that ':' (ctx:VxV) #44: FILE: drivers/gpu/drm/i915/display/intel_vdsc_regs.h:55: +#define DSCC_PPS(pps) ((pps < 12) ? _MMIO(_DSCC_PPS_0 + (pps) * 4):_MMIO(_DSCC_PPS_0 + (pps + 12) * 4)) ^ -:44: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pps' - possible side-effects? #44: FILE: drivers/gpu/drm/i915/display/intel_vdsc_regs.h:55: +#define DSCC_PPS(pps) ((pps < 12) ? _MMIO(_DSCC_PPS_0 + (pps) * 4):_MMIO(_DSCC_PPS_0 + (pps + 12) * 4)) -:44: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'pps' may be better as '(pps)' to avoid precedence issues #44: FILE: drivers/gpu/drm/i915/display/intel_vdsc_regs.h:55: +#define DSCC_PPS(pps) ((pps < 12) ? _MMIO(_DSCC_PPS_0 + (pps) * 4):_MMIO(_DSCC_PPS_0 + (pps + 12) * 4)) total: 0 errors, 4 warnings, 6 checks, 10 lines checked
