On Tue, Jan 16, 2024 at 09:56:34AM +0200, Ville Syrjala wrote: > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > Currently we assume that we bind the BIOS fb exactly into the same > ggtt address where the BIOS left it. That is about to change, and > in order to keep intel_reuse_initial_plane_obj() working as intended > we need to compare the original ggtt offset (called 'base' here) > as opposed to the actual vma ggtt offset we selected. Otherwise > the first plane could change the ggtt offset, and then subsequent > planes would no longer notice that they are in fact using the same > ggtt offset that the first plane was already using. Thus the reuse > check will fail and we proceed to turn off these subsequent planes. > > TODO: would probably make more sense to do the pure readout first > for all the planes, then check for fb reuse, and only then proceed > to pin the object into the final location in the ggtt... > > Cc: Paz Zcharya <pazz@xxxxxxxxxxxx> > Reviewed-by: Andrzej Hajda <andrzej.hajda@xxxxxxxxx> > Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> Hi Ville, Thank you so much for this incredible series. It solves the issue regarding MTL initial plane readout that Andrzej Hajda and I worked on in https://patchwork.freedesktop.org/patch/570811/?series=127130&rev=2 In addition, it solved the issue with the new GOP. I tested it on two different devices with Meteor Lake and it worked perfectly: no i915 errors, no flickers or observable issues. Tested-by: Paz Zcharya <pazz@xxxxxxxxxxxx>
