== Series Details == Series: drm/i915/display: Move some LNL registers URL : https://patchwork.freedesktop.org/series/129226/ State : warning == Summary == Error: dim checkpatch failed b7a2f39f8e10 drm/i915/xe2lpd: Move D2D enable/disable -:87: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 23) #87: FILE: drivers/gpu/drm/i915/display/intel_ddi.c:3345: + if (DISPLAY_VER(dev_priv) >= 20) + buf_ctl |= XE2LPD_DDI_BUF_D2D_LINK_ENABLE; total: 0 errors, 1 warnings, 0 checks, 80 lines checked 5b1009e12a6b drm/i915/xe2lpd: Move registers to PICA -:384: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'port' - possible side-effects? #384: FILE: drivers/gpu/drm/i915/display/intel_cx0_phy_regs.h:27: +#define __xe2lpd_port_idx(port) \ + (port >= PORT_TC1 ? port : PORT_TC4 + 1 + port - PORT_A) -:384: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'port' may be better as '(port)' to avoid precedence issues #384: FILE: drivers/gpu/drm/i915/display/intel_cx0_phy_regs.h:27: +#define __xe2lpd_port_idx(port) \ + (port >= PORT_TC1 ? port : PORT_TC4 + 1 + port - PORT_A) -:397: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'port' - possible side-effects? #397: FILE: drivers/gpu/drm/i915/display/intel_cx0_phy_regs.h:39: +#define XELPDP_PORT_M2P_MSGBUS_CTL(i915__, port, lane) \ + (DISPLAY_VER(i915__) >= 20 ? \ + _XELPDP_PORT_M2P_MSGBUS_CTL(__xe2lpd_port_idx(port), lane) : \ + _XELPDP_PORT_M2P_MSGBUS_CTL(port, lane)) -:397: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'lane' - possible side-effects? #397: FILE: drivers/gpu/drm/i915/display/intel_cx0_phy_regs.h:39: +#define XELPDP_PORT_M2P_MSGBUS_CTL(i915__, port, lane) \ + (DISPLAY_VER(i915__) >= 20 ? \ + _XELPDP_PORT_M2P_MSGBUS_CTL(__xe2lpd_port_idx(port), lane) : \ + _XELPDP_PORT_M2P_MSGBUS_CTL(port, lane)) -:415: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'port' - possible side-effects? #415: FILE: drivers/gpu/drm/i915/display/intel_cx0_phy_regs.h:59: +#define XELPDP_PORT_P2M_MSGBUS_STATUS(i915__, port, lane) \ + (DISPLAY_VER(i915__) >= 20 ? \ + _XELPDP_PORT_P2M_MSGBUS_STATUS(__xe2lpd_port_idx(port), lane) : \ + _XELPDP_PORT_P2M_MSGBUS_STATUS(port, lane)) -:415: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'lane' - possible side-effects? #415: FILE: drivers/gpu/drm/i915/display/intel_cx0_phy_regs.h:59: +#define XELPDP_PORT_P2M_MSGBUS_STATUS(i915__, port, lane) \ + (DISPLAY_VER(i915__) >= 20 ? \ + _XELPDP_PORT_P2M_MSGBUS_STATUS(__xe2lpd_port_idx(port), lane) : \ + _XELPDP_PORT_P2M_MSGBUS_STATUS(port, lane)) -:432: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'port' - possible side-effects? #432: FILE: drivers/gpu/drm/i915/display/intel_cx0_phy_regs.h:90: +#define XELPDP_PORT_BUF_CTL1(i915__, port) \ + (DISPLAY_VER(i915__) >= 20 ? \ + _XELPDP_PORT_BUF_CTL1(__xe2lpd_port_idx(port)) : \ + _XELPDP_PORT_BUF_CTL1(port)) -:450: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'port' - possible side-effects? #450: FILE: drivers/gpu/drm/i915/display/intel_cx0_phy_regs.h:115: +#define XELPDP_PORT_BUF_CTL2(i915__, port) \ + (DISPLAY_VER(i915__) >= 20 ? \ + _XELPDP_PORT_BUF_CTL2(__xe2lpd_port_idx(port)) : \ + _XELPDP_PORT_BUF_CTL2(port)) -:467: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'port' - possible side-effects? #467: FILE: drivers/gpu/drm/i915/display/intel_cx0_phy_regs.h:138: +#define XELPDP_PORT_BUF_CTL3(i915__, port) \ + (DISPLAY_VER(i915__) >= 20 ? \ + _XELPDP_PORT_BUF_CTL3(__xe2lpd_port_idx(port)) : \ + _XELPDP_PORT_BUF_CTL3(port)) -:484: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'port' - possible side-effects? #484: FILE: drivers/gpu/drm/i915/display/intel_cx0_phy_regs.h:161: +#define XELPDP_PORT_MSGBUS_TIMER(i915__, port, lane) \ + (DISPLAY_VER(i915__) >= 20 ? \ + _XELPDP_PORT_MSGBUS_TIMER(__xe2lpd_port_idx(port), lane) : \ + _XELPDP_PORT_MSGBUS_TIMER(port, lane)) -:484: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'lane' - possible side-effects? #484: FILE: drivers/gpu/drm/i915/display/intel_cx0_phy_regs.h:161: +#define XELPDP_PORT_MSGBUS_TIMER(i915__, port, lane) \ + (DISPLAY_VER(i915__) >= 20 ? \ + _XELPDP_PORT_MSGBUS_TIMER(__xe2lpd_port_idx(port), lane) : \ + _XELPDP_PORT_MSGBUS_TIMER(port, lane)) -:501: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'port' - possible side-effects? #501: FILE: drivers/gpu/drm/i915/display/intel_cx0_phy_regs.h:178: +#define XELPDP_PORT_CLOCK_CTL(i915__, port) \ + (DISPLAY_VER(i915__) >= 20 ? \ + _XELPDP_PORT_CLOCK_CTL(__xe2lpd_port_idx(port)) : \ + _XELPDP_PORT_CLOCK_CTL(port)) total: 0 errors, 0 warnings, 12 checks, 574 lines checked
