> -----Original Message----- > From: Intel-gfx <intel-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Jouni > Högander > Sent: Wednesday, January 10, 2024 6:43 PM > To: intel-gfx@xxxxxxxxxxxxxxxxxxxxx > Subject: [PATCH v2 03/13] drm/i915/psr: Do not check alpm on DP or > capability change for panel replay > > Alpm is eDP specific. Do not check if not eDP. Also panel replay doesn't know > about capability changes -> no need to check that. > > Signed-off-by: Jouni Högander <jouni.hogander@xxxxxxxxx> > --- > drivers/gpu/drm/i915/display/intel_psr.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_psr.c > b/drivers/gpu/drm/i915/display/intel_psr.c > index 3e287a9f0e09..a9421dd092c5 100644 > --- a/drivers/gpu/drm/i915/display/intel_psr.c > +++ b/drivers/gpu/drm/i915/display/intel_psr.c > @@ -2989,8 +2989,11 @@ void intel_psr_short_pulse(struct intel_dp > *intel_dp) > /* clear status register */ > drm_dp_dpcd_writeb(&intel_dp->aux, DP_PSR_ERROR_STATUS, > error_status); > > - psr_alpm_check(intel_dp); > - psr_capability_changed_check(intel_dp); > + if (intel_dp_is_edp(intel_dp)) > + psr_alpm_check(intel_dp); > + > + if (!psr->panel_replay_enabled) > + psr_capability_changed_check(intel_dp); There is a CAN_PSR() check starting of the function intel_psr_short_pulse() which will take care non-edp and panel replay case, so do you see any gap there? Regards, Animesh > > exit: > mutex_unlock(&psr->lock); > -- > 2.34.1
