On Thu, Jan 04, 2024 at 06:46:00PM +0200, Jani Nikula wrote: > intel_wakeref_t is supposed to be a mostly opaque cookie to its > users. It should only be checked for being non-zero and set to > zero. Debug logging its actual value is meaningless. Switch to just > debug logging whether the async_put_wakeref is non-zero. > > The issue dates back to much earlier than > commit b49e894c3fd8 ("drm/i915: Replace custom intel runtime_pm tracker > with ref_tracker library"), but this is the one that brought about a > build failure due to the printf format. > > Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> > Closes: https://lore.kernel.org/r/20240102111222.2db11208@xxxxxxxxxxxxxxxx > Fixes: b49e894c3fd8 ("drm/i915: Replace custom intel runtime_pm tracker with ref_tracker library") > Cc: Andrzej Hajda <andrzej.hajda@xxxxxxxxx> > Cc: Imre Deak <imre.deak@xxxxxxxxx> > Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx> Reviewed-by: Imre Deak <imre.deak@xxxxxxxxx> > --- > drivers/gpu/drm/i915/display/intel_display_power.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c > index 5f091502719b..6fd4fa52253a 100644 > --- a/drivers/gpu/drm/i915/display/intel_display_power.c > +++ b/drivers/gpu/drm/i915/display/intel_display_power.c > @@ -405,8 +405,8 @@ print_async_put_domains_state(struct i915_power_domains *power_domains) > struct drm_i915_private, > display.power.domains); > > - drm_dbg(&i915->drm, "async_put_wakeref %lu\n", > - power_domains->async_put_wakeref); > + drm_dbg(&i915->drm, "async_put_wakeref: %s\n", > + str_yes_no(power_domains->async_put_wakeref)); > > print_power_domains(power_domains, "async_put_domains[0]", > &power_domains->async_put_domains[0]); > -- > 2.39.2 >