On Wed, 2024-01-03 at 16:00 +0200, Imre Deak wrote:
> On Wed, Jan 03, 2024 at 01:37:08PM +0200, Hogander, Jouni wrote:
> > > > > [...]
> > > > > diff --git a/drivers/gpu/drm/i915/display/intel_psr.c
> > > > > b/drivers/gpu/drm/i915/display/intel_psr.c
> > > > > index 494d08817d71e..b5b9340e505e3 100644
> > > > > --- a/drivers/gpu/drm/i915/display/intel_psr.c
> > > > > +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> > > > > @@ -3310,11 +3310,8 @@ void
> > > > > intel_psr_connector_debugfs_add(struct
> > > > > intel_connector *connector)
> > > > > struct drm_i915_private *i915 = to_i915(connector-
> > > > > >base.dev);
> > > > > struct dentry *root = connector->base.debugfs_entry;
> > > > >
> > > > > - if (connector->base.connector_type !=
> > > > > DRM_MODE_CONNECTOR_eDP)
> > > > > {
> > > > > - if (!(HAS_DP20(i915) &&
> > > > > - connector->base.connector_type ==
> > > > > DRM_MODE_CONNECTOR_DisplayPort))
> > > > > - return;
> > > > > - }
> > > > > + if (connector->base.connector_type !=
> > > > > DRM_MODE_CONNECTOR_eDP)
> > > > > + return;
> > > >
> > > > Would it be possible to disable it only for MST connector? I
> > > > think
> > > > this is disabling it also for DP SST, no?
> > >
> > > Yes, it keeps it enabled only for eDP. It could be enabled for
> > > SST as
> > > well yes, but I thought as a fix the above is better, adding
> > > support
> > > for other connector types as a follow up.
> >
> > if (connector->mst_port || !(HAS_DP20(i915) &&
> > connectorbase.connector_type == DRM_MODE_CONNECTOR_DisplayPort))
> > return;
> >
> > Is it possible to use this instead?
>
> Looking through it I don't see a problem on SST connectors either, so
> I'd rather leave the entries enabled for them on all platforms, that
> is
>
> if ((connector_type != DRM_MODE_CONNECTOR_eDP &&
> connector_type != DRM_MODE_CONNECTOR_DisplayPort) ||
> connector->mst_port)
> return;
Sounds good. That is anyways same what is done for PSR as well.
BR,
Jouni Högander
>
> > BR,
> >
> > Jouni Högander
> >
> > >
> > > > BR,
> > > >
> > > > Jouni Högander
> > > > >
> > > > > debugfs_create_file("i915_psr_sink_status", 0444,
> > > > > root,
> > > > > connector,
> > > > > &i915_psr_sink_status_fops);
> > > >
> >
