On Mon, Dec 18, 2023 at 10:51:03AM -0800, Dixit, Ashutosh wrote: > On Mon, 18 Dec 2023 06:57:14 -0800, Thomas Hellström wrote: > > > > > > On 12/18/23 15:30, Rodrigo Vivi wrote: > > > Ideally this header could be included without the CONFIG_FAULT_INJECTION > > > and it would take care itself for the includes it needs. > > > So, let's temporary workaround this by moving this below and including > > > only when CONFIG_FAULT_INJECTION is selected to avoid build breakages. > > > > > > Another solution would be us including the linux/types.h as well, but > > > this creates unnecessary cases. > > > > > > Reference: https://lore.kernel.org/all/20230816134748.979231-1-himal.prasad.ghimiray@xxxxxxxxx/ > > > Cc: Himal Prasad Ghimiray <himal.prasad.ghimiray@xxxxxxxxx> > > > Cc: Oded Gabbay <ogabbay@xxxxxxxxxx> > > > Cc: Thomas Hellström <thomas.hellstrom@xxxxxxxxxxxxxxx> > > > Cc: Lucas De Marchi <lucas.demarchi@xxxxxxxxx> > > > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> > > LGTM. > > > > Reviewed-by: Thomas Hellström <thomas.hellstrom@xxxxxxxxxxxxxxx> > > Hmm, msm/msm_drv.c doesn't seem to need to do this. because it also imports the types.h: drivers/gpu/drm/msm/msm_drv.h:#include <linux/types.h> > Anyway maybe ok for a > temporary fix... yes, it is a temporary hammer. But maybe we don't need this if Andrew acks to get this through drm-xe-next -> drm-next: https://lore.kernel.org/all/a5o2opdfsfnbptrrbvillogft2uqp73w4icu3mdmmwtvoqmdr2@y2fbrc6t4aew/
