On Mon, 2023-11-20 at 17:17 +0000, Manna, Animesh wrote:
>
>
> > -----Original Message-----
> > From: Hogander, Jouni <jouni.hogander@xxxxxxxxx>
> > Sent: Monday, November 20, 2023 6:32 PM
> > To: intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> > Cc: Hogander, Jouni <jouni.hogander@xxxxxxxxx>; Manna, Animesh
> > <animesh.manna@xxxxxxxxx>
> > Subject: [PATCH] drm/i915/display: Do not check psr2 if psr/panel
> > replay is
> > not supported
> >
> > Do not continue to psr2 checks if psr or panel replay is not
> > supported.
> >
> > Cc: Animesh Manna <animesh.manna@xxxxxxxxx>
> >
> > Fixes: b8cf5b5d266e ("drm/i915/panelreplay: Initializaton and
> > compute
> > config for panel replay")
> > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/9670
> > Signed-off-by: Jouni Högander <jouni.hogander@xxxxxxxxx>
>
> LGTM.
> Reviewed-by: Animesh Manna <animesh.manna@xxxxxxxxx>
Thank you Animesh for your review. This is now pushed into drm-intel-
next.
BR,
Jouni Högander
>
> > ---
> > drivers/gpu/drm/i915/display/intel_psr.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_psr.c
> > b/drivers/gpu/drm/i915/display/intel_psr.c
> > index 8d180132a74b..9aa1c269cfef 100644
> > --- a/drivers/gpu/drm/i915/display/intel_psr.c
> > +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> > @@ -1373,6 +1373,9 @@ void intel_psr_compute_config(struct intel_dp
> > *intel_dp,
> > else
> > crtc_state->has_psr = _psr_compute_config(intel_dp,
> > crtc_state);
> >
> > + if (!(crtc_state->has_panel_replay || crtc_state->has_psr))
> > + return;
> > +
> > crtc_state->has_psr2 = intel_psr2_config_valid(intel_dp,
> > crtc_state);
> >
> > crtc_state->infoframes.enable |=
> > intel_hdmi_infoframe_enable(DP_SDP_VSC);
> > --
> > 2.34.1
>
