Re: [PATCH] drm/ttm: replace busy placement with flags v2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Somalapuram,

kernel test robot noticed the following build errors:

[auto build test ERROR on drm-tip/drm-tip]

url:    https://github.com/intel-lab-lkp/linux/commits/Somalapuram-Amaranath/drm-ttm-replace-busy-placement-with-flags-v2/20231109-104055
base:   git://anongit.freedesktop.org/drm/drm-tip drm-tip
patch link:    https://lore.kernel.org/r/20231109023843.32326-1-Amaranath.Somalapuram%40amd.com
patch subject:  [PATCH] drm/ttm: replace busy placement with flags v2
config: arc-randconfig-001-20231109 (https://download.01.org/0day-ci/archive/20231109/202311091529.KIl0H6z5-lkp@xxxxxxxxx/config)
compiler: arc-elf-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231109/202311091529.KIl0H6z5-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311091529.KIl0H6z5-lkp@xxxxxxxxx/

All errors (new ones prefixed by >>):

   drivers/gpu/drm/loongson/lsdc_ttm.c: In function 'lsdc_bo_set_placement':
>> drivers/gpu/drm/loongson/lsdc_ttm.c:57:24: error: 'struct ttm_placement' has no member named 'busy_placement'; did you mean 'num_placement'?
      57 |         lbo->placement.busy_placement = lbo->placements;
         |                        ^~~~~~~~~~~~~~
         |                        num_placement
>> drivers/gpu/drm/loongson/lsdc_ttm.c:80:24: error: 'struct ttm_placement' has no member named 'num_busy_placement'; did you mean 'num_placement'?
      80 |         lbo->placement.num_busy_placement = c;
         |                        ^~~~~~~~~~~~~~~~~~
         |                        num_placement


vim +57 drivers/gpu/drm/loongson/lsdc_ttm.c

f39db26c54281d Sui Jingfeng 2023-06-15  46  
f39db26c54281d Sui Jingfeng 2023-06-15  47  static void lsdc_bo_set_placement(struct lsdc_bo *lbo, u32 domain)
f39db26c54281d Sui Jingfeng 2023-06-15  48  {
f39db26c54281d Sui Jingfeng 2023-06-15  49  	u32 c = 0;
f39db26c54281d Sui Jingfeng 2023-06-15  50  	u32 pflags = 0;
f39db26c54281d Sui Jingfeng 2023-06-15  51  	u32 i;
f39db26c54281d Sui Jingfeng 2023-06-15  52  
f39db26c54281d Sui Jingfeng 2023-06-15  53  	if (lbo->tbo.base.size <= PAGE_SIZE)
f39db26c54281d Sui Jingfeng 2023-06-15  54  		pflags |= TTM_PL_FLAG_TOPDOWN;
f39db26c54281d Sui Jingfeng 2023-06-15  55  
f39db26c54281d Sui Jingfeng 2023-06-15  56  	lbo->placement.placement = lbo->placements;
f39db26c54281d Sui Jingfeng 2023-06-15 @57  	lbo->placement.busy_placement = lbo->placements;
f39db26c54281d Sui Jingfeng 2023-06-15  58  
f39db26c54281d Sui Jingfeng 2023-06-15  59  	if (domain & LSDC_GEM_DOMAIN_VRAM) {
f39db26c54281d Sui Jingfeng 2023-06-15  60  		lbo->placements[c].mem_type = TTM_PL_VRAM;
f39db26c54281d Sui Jingfeng 2023-06-15  61  		lbo->placements[c++].flags = pflags;
f39db26c54281d Sui Jingfeng 2023-06-15  62  	}
f39db26c54281d Sui Jingfeng 2023-06-15  63  
f39db26c54281d Sui Jingfeng 2023-06-15  64  	if (domain & LSDC_GEM_DOMAIN_GTT) {
f39db26c54281d Sui Jingfeng 2023-06-15  65  		lbo->placements[c].mem_type = TTM_PL_TT;
f39db26c54281d Sui Jingfeng 2023-06-15  66  		lbo->placements[c++].flags = pflags;
f39db26c54281d Sui Jingfeng 2023-06-15  67  	}
f39db26c54281d Sui Jingfeng 2023-06-15  68  
f39db26c54281d Sui Jingfeng 2023-06-15  69  	if (domain & LSDC_GEM_DOMAIN_SYSTEM) {
f39db26c54281d Sui Jingfeng 2023-06-15  70  		lbo->placements[c].mem_type = TTM_PL_SYSTEM;
f39db26c54281d Sui Jingfeng 2023-06-15  71  		lbo->placements[c++].flags = 0;
f39db26c54281d Sui Jingfeng 2023-06-15  72  	}
f39db26c54281d Sui Jingfeng 2023-06-15  73  
f39db26c54281d Sui Jingfeng 2023-06-15  74  	if (!c) {
f39db26c54281d Sui Jingfeng 2023-06-15  75  		lbo->placements[c].mem_type = TTM_PL_SYSTEM;
f39db26c54281d Sui Jingfeng 2023-06-15  76  		lbo->placements[c++].flags = 0;
f39db26c54281d Sui Jingfeng 2023-06-15  77  	}
f39db26c54281d Sui Jingfeng 2023-06-15  78  
f39db26c54281d Sui Jingfeng 2023-06-15  79  	lbo->placement.num_placement = c;
f39db26c54281d Sui Jingfeng 2023-06-15 @80  	lbo->placement.num_busy_placement = c;
f39db26c54281d Sui Jingfeng 2023-06-15  81  
f39db26c54281d Sui Jingfeng 2023-06-15  82  	for (i = 0; i < c; ++i) {
f39db26c54281d Sui Jingfeng 2023-06-15  83  		lbo->placements[i].fpfn = 0;
f39db26c54281d Sui Jingfeng 2023-06-15  84  		lbo->placements[i].lpfn = 0;
f39db26c54281d Sui Jingfeng 2023-06-15  85  	}
f39db26c54281d Sui Jingfeng 2023-06-15  86  }
f39db26c54281d Sui Jingfeng 2023-06-15  87  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki



[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux