✗ Fi.CI.CHECKPATCH: warning for Panel replay phase1 implementation (rev10)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



== Series Details ==

Series: Panel replay phase1 implementation (rev10)
URL   : https://patchwork.freedesktop.org/series/94470/
State : warning

== Summary ==

Error: dim checkpatch failed
f025bc5ed357 drm/panelreplay: dpcd register definition for panelreplay
a6ba947cd35c drm/i915/psr: Move psr specific dpcd init into own function
d0b4de45d90a drm/i915/panelreplay: Initializaton and compute config for panel replay
-:366: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'intel_dp' - possible side-effects?
#366: FILE: drivers/gpu/drm/i915/display/intel_psr.h:24:
+#define CAN_PSR(intel_dp) ((intel_dp)->psr.sink_support && \
+			   (intel_dp)->psr.source_support)

-:369: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'intel_dp' - possible side-effects?
#369: FILE: drivers/gpu/drm/i915/display/intel_psr.h:27:
+#define CAN_PANEL_REPLAY(intel_dp) ((intel_dp)->psr.sink_panel_replay_support && \
+				    (intel_dp)->psr.source_panel_replay_support)

total: 0 errors, 0 warnings, 2 checks, 289 lines checked
5225e39b90ad drm/i915/panelreplay: Enable panel replay dpcd initialization for DP
bf1255857ce0 drm/i915/panelreplay: enable/disable panel replay
96064a75ad28 drm/i915/panelreplay: Debugfs support for panel replay
-:111: ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#111: FILE: drivers/gpu/drm/i915/display/intel_psr.c:3239:
+static const char *psr_mode_str(struct intel_dp *intel_dp) {

-:114: ERROR:SPACING: space required before the open parenthesis '('
#114: FILE: drivers/gpu/drm/i915/display/intel_psr.c:3242:
+	else if(intel_dp->psr.enabled)

-:171: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 24)
#171: FILE: drivers/gpu/drm/i915/display/intel_psr.c:3300:
 	if (error_status & (DP_PSR_RFB_STORAGE_ERROR |
[...]
+			seq_puts(m, ":\n");

total: 2 errors, 1 warnings, 0 checks, 176 lines checked





[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux