✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915: Remove unused for_each_uabi_class_engine

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



== Series Details ==

Series: series starting with [1/2] drm/i915: Remove unused for_each_uabi_class_engine
URL   : https://patchwork.freedesktop.org/series/125886/
State : warning

== Summary ==

Error: dim checkpatch failed
b3e28ced9c21 drm/i915: Remove unused for_each_uabi_class_engine
-:6: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#6: 
Unused macro after 99919be74aa3 ("drm/i915/gem: Zap the i915_gem_object_blt code")

-:6: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 99919be74aa3 ("drm/i915/gem: Zap the i915_gem_object_blt code")'
#6: 
Unused macro after 99919be74aa3 ("drm/i915/gem: Zap the i915_gem_object_blt code")

total: 1 errors, 1 warnings, 0 checks, 11 lines checked
d4b892a3d2b1 drm/i915: Move for_each_engine* out of i915_drv.h
-:34: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#34: FILE: drivers/gpu/drm/i915/gt/intel_gt.h:175:
+#define for_each_engine(engine__, gt__, id__) \
+	for ((id__) = 0; \
+	     (id__) < I915_NUM_ENGINES; \
+	     (id__)++) \
+		for_each_if ((engine__) = (gt__)->engine[(id__)])

-:34: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'id__' - possible side-effects?
#34: FILE: drivers/gpu/drm/i915/gt/intel_gt.h:175:
+#define for_each_engine(engine__, gt__, id__) \
+	for ((id__) = 0; \
+	     (id__) < I915_NUM_ENGINES; \
+	     (id__)++) \
+		for_each_if ((engine__) = (gt__)->engine[(id__)])

-:38: WARNING:SPACING: space prohibited between function name and open parenthesis '('
#38: FILE: drivers/gpu/drm/i915/gt/intel_gt.h:179:
+		for_each_if ((engine__) = (gt__)->engine[(id__)])

-:41: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'gt__' - possible side-effects?
#41: FILE: drivers/gpu/drm/i915/gt/intel_gt.h:182:
+#define for_each_engine_masked(engine__, gt__, mask__, tmp__) \
+	for ((tmp__) = (mask__) & (gt__)->info.engine_mask; \
+	     (tmp__) ? \
+	     ((engine__) = (gt__)->engine[__mask_next_bit(tmp__)]), 1 : \
+	     0;)

-:41: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'tmp__' - possible side-effects?
#41: FILE: drivers/gpu/drm/i915/gt/intel_gt.h:182:
+#define for_each_engine_masked(engine__, gt__, mask__, tmp__) \
+	for ((tmp__) = (mask__) & (gt__)->info.engine_mask; \
+	     (tmp__) ? \
+	     ((engine__) = (gt__)->engine[__mask_next_bit(tmp__)]), 1 : \
+	     0;)

total: 1 errors, 1 warnings, 3 checks, 64 lines checked





[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux