✗ Fi.CI.CHECKPATCH: warning for fix DRM_USE_DYNAMIC_DEBUG=y regression (rev5)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



== Series Details ==

Series: fix DRM_USE_DYNAMIC_DEBUG=y regression (rev5)
URL   : https://patchwork.freedesktop.org/series/125063/
State : warning

== Summary ==

Error: dim checkpatch failed
4929242ff04f test-dyndbg: fixup CLASSMAP usage error
369c6289e760 dyndbg: reword "class unknown, " to "class:_UNKNOWN_"
298212933902 dyndbg: make ddebug_class_param union members same size
bb9d43099e1f dyndbg: replace classmap list with a vector
9053c45926cc dyndbg: ddebug_apply_class_bitmap - add module arg, select on it
4effa4ae444f dyndbg: split param_set_dyndbg_classes to module/wrapper fns
c60c94fb33fc dyndbg: drop NUM_TYPE_ARRAY
561d6d49eb5d dyndbg: reduce verbose/debug clutter
08c98906a7af dyndbg: silence debugs with no-change updates
268c7816d589 dyndbg: tighten ddebug_class_name() 1st arg type
74408cbc658b dyndbg: tighten fn-sig of ddebug_apply_class_bitmap
b64725e3843a dyndbg: reduce verbose=3 messages in ddebug_add_module
9ebe4353b36f dyndbg-API: remove DD_CLASS_TYPE_(DISJOINT|LEVEL)_NAMES and code
698fe9e39965 dyndbg-API: fix CONFIG_DRM_USE_DYNAMIC_DEBUG regression
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 6, in <module>
    from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
-:451: CHECK:MACRO_ARG_REUSE: Macro argument reuse '_var' - possible side-effects?
#451: FILE: include/linux/dynamic_debug.h:121:
+#define DYNDBG_CLASSMAP_USE_(_var, _uname)				\
+	extern struct ddebug_class_map _var;				\
+	static struct ddebug_class_user __aligned(8) __used		\
+	__section("__dyndbg_class_users") _uname = {			\
+		.user_mod_name = KBUILD_MODNAME,			\
+		.map = &(_var),						\
 	}

-:771: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#771: FILE: lib/dynamic_debug.c:1254:
+	for (i = 0, cli = di->class_users; i < di->num_class_users; i++, cli++) {
+

-:776: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#776: FILE: lib/dynamic_debug.c:1259:
+		if (!strcmp(cli->user_mod_name, dt->mod_name)) {
+

-:877: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'base' may be better as '(base)' to avoid precedence issues
#877: FILE: lib/test_dynamic_debug.c:36:
+#define CLASSMAP_BITMASK(width, base) (((1UL << (width)) - 1) << base)

-:992: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#992: 
new file mode 100644

total: 0 errors, 1 warnings, 4 checks, 738 lines checked
42f707d2442b dyndbg: refactor ddebug_classparam_clamp_input
73fc692a7e54 dyndbg-API: promote DYNDBG_CLASSMAP_PARAM to API
0c8745b5707c dyndbg-doc: add classmap info to howto
52d0ffdcbfec dyndbg: reserve flag bit _DPRINTK_FLAGS_PREFIX_CACHED
-:30: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#30: FILE: include/linux/dynamic_debug.h:41:
+#define _DPRINTK_FLAGS_PREFIX_CACHED	(1<<7)
                                     	  ^

total: 0 errors, 0 warnings, 1 checks, 7 lines checked
fea64f3506f5 dyndbg: add _DPRINTK_FLAGS_INCL_LOOKUP
31983f133793 dyndbg: refactor *dynamic_emit_prefix
f01c82d0f499 drm: use correct ccflags-y spelling
6645a20cbc0b drm-drivers: DRM_CLASSMAP_USE in 2nd batch of drivers, helpers
b6f3bdc05afd drm: restore CONFIG_DRM_USE_DYNAMIC_DEBUG un-BROKEN





[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux