Re: [PATCH RESEND 2/3] drm/i915: move gpu error debugfs to i915_gpu_error.c

[Jani Nikula <jani.nikula@xxxxxxxxx>]

On Tue, 31 Oct 2023, Nirmoy Das <nirmoy.das@xxxxxxxxxxxxxxx> wrote:
> On 10/31/2023 1:45 PM, Jani Nikula wrote:
>> +void i915_gpu_error_debugfs_register(struct drm_i915_private *i915)
>> +{
>> +	struct drm_minor *minor = i915->drm.primary;
>> +
>> +	debugfs_create_file("i915_error_state", 0644,
>
> nit: s/0644/S_IRUGO | S_IWUSR

The direction pretty much across the kernel is to go towards octal
permissions because the macros are harder to understand.

> Reviewed-by: Nirmoy Das <nirmoy.das@xxxxxxxxx>

Thanks,
Jani.

-- 
Jani Nikula, Intel