On Mon, 2023-10-16 at 14:16 +0300, Jouni Högander wrote: > Signed-off-by: Jouni Högander <jouni.hogander@xxxxxxxxx> > --- > drivers/gpu/drm/i915/display/intel_display_params.c | 4 ++++ > drivers/gpu/drm/i915/display/intel_display_params.h | 3 ++- > drivers/gpu/drm/i915/display/intel_lvds.c | 4 ++-- > drivers/gpu/drm/i915/i915_params.c | 4 ---- > drivers/gpu/drm/i915/i915_params.h | 1 - > 5 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_display_params.c b/drivers/gpu/drm/i915/display/intel_display_params.c > index 72f1782e27fe..cdc42bc575b8 100644 > --- a/drivers/gpu/drm/i915/display/intel_display_params.c > +++ b/drivers/gpu/drm/i915/display/intel_display_params.c > @@ -30,6 +30,10 @@ static struct intel_display_params intel_display_modparams __read_mostly = { > intel_display_param_named_unsafe(vbt_firmware, charp, 0400, > "Load VBT from specified file under /lib/firmware"); > > +intel_display_param_named_unsafe(lvds_channel_mode, int, 0400, > + "Specify LVDS channel mode " > + "(0=probe BIOS [default], 1=single-channel, 2=dual-channel)"); > + > intel_display_param_named_unsafe(enable_fbc, int, 0400, > "Enable frame buffer compression for power savings " > "(default: -1 (use per-chip default))"); > diff --git a/drivers/gpu/drm/i915/display/intel_display_params.h b/drivers/gpu/drm/i915/display/intel_display_params.h > index a6f37c55523d..a4988ef44837 100644 > --- a/drivers/gpu/drm/i915/display/intel_display_params.h > +++ b/drivers/gpu/drm/i915/display/intel_display_params.h > @@ -25,7 +25,8 @@ struct drm_i915_private; > */ > #define INTEL_DISPLAY_PARAMS_FOR_EACH(param) \ > param(char *, vbt_firmware, NULL, 0400) \ > - param(int, enable_fbc, -1, 0600) \ > + param(int, lvds_channel_mode, 0, 0400) \ > + param(int, enable_fbc, -1, 0600) \ The enable_fbc line shouldn't be changed here. Was there some missing spaces? If so, it should be fixed in the patch that added enable_fbc. With this fixed: Reviewed-by: Luca Coelho <luciano.coelho@xxxxxxxxx> -- Cheers, Luca.