Hi Jonathan, kernel test robot noticed the following build errors: [auto build test ERROR on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Jonathan-Cavitt/drm-i915-Use-selective-tlb-invalidations-where-supported/20231011-034501 base: git://anongit.freedesktop.org/drm/drm-tip drm-tip patch link: https://lore.kernel.org/r/20231010184423.2118908-4-jonathan.cavitt%40intel.com patch subject: [PATCH dii-client 2/2] drm/i915: Use selective tlb invalidations where supported config: x86_64-rhel-8.3-rust (https://download.01.org/0day-ci/archive/20231012/202310120817.oZ9qYP5h-lkp@xxxxxxxxx/config) compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231012/202310120817.oZ9qYP5h-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202310120817.oZ9qYP5h-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): >> drivers/gpu/drm/i915/i915_vma.c:1343:4: error: expected ')' u64 start, u64 size) ^ drivers/gpu/drm/i915/i915_vma.c:1342:24: note: to match this '(' void vma_invalidate_tlb(struct i915_address_space *vm, u32 *tlb ^ >> drivers/gpu/drm/i915/i915_vma.c:1342:6: error: conflicting types for 'vma_invalidate_tlb' void vma_invalidate_tlb(struct i915_address_space *vm, u32 *tlb ^ drivers/gpu/drm/i915/i915_vma.h:263:6: note: previous declaration is here void vma_invalidate_tlb(struct i915_address_space *vm, u32 *tlb, ^ >> drivers/gpu/drm/i915/i915_vma.c:1360:42: error: use of undeclared identifier 'start'; did you mean 'stac'? if (!intel_gt_invalidate_tlb_range(gt, start, size)) ^~~~~ stac arch/x86/include/asm/smap.h:36:29: note: 'stac' declared here static __always_inline void stac(void) ^ >> drivers/gpu/drm/i915/i915_vma.c:1360:49: error: use of undeclared identifier 'size'; did you mean 'ksize'? if (!intel_gt_invalidate_tlb_range(gt, start, size)) ^~~~ ksize include/linux/slab.h:245:8: note: 'ksize' declared here size_t ksize(const void *objp); ^ 4 errors generated. vim +1343 drivers/gpu/drm/i915/i915_vma.c 1341 > 1342 void vma_invalidate_tlb(struct i915_address_space *vm, u32 *tlb > 1343 u64 start, u64 size) 1344 { 1345 struct intel_gt *gt; 1346 int id; 1347 1348 if (!tlb) 1349 return; 1350 1351 /* 1352 * Before we release the pages that were bound by this vma, we 1353 * must invalidate all the TLBs that may still have a reference 1354 * back to our physical address. It only needs to be done once, 1355 * so after updating the PTE to point away from the pages, record 1356 * the most recent TLB invalidation seqno, and if we have not yet 1357 * flushed the TLBs upon release, perform a full invalidation. 1358 */ 1359 for_each_gt(gt, vm->i915, id) { > 1360 if (!intel_gt_invalidate_tlb_range(gt, start, size)) 1361 WRITE_ONCE(tlb[id], 1362 intel_gt_next_invalidate_tlb_full(gt)); 1363 } 1364 } 1365 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
