Re: drm/i915/mtl: Remove the 'force_probe' requirement for Meteor Lake

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Shawn,

On Wed, Oct 11, 2023 at 10:03:08AM +0200, Lee, Shawn C wrote:
> > From: Radhakrishna Sripada <radhakrishna.sripada@xxxxxxxxx>
> > 
> > Meteor Lake has demonstrated consistent stability for some time.
> > All user-space API modifications tide to its core platform
> > functions are operational.
> > 
> > The necessary firmware components are set up and comprehensive
> > testing has been condused over a period.
> > 
> > Given the recent faborable CI results, as well, we believe it's
> > time to eliminate the 'force_probe' prerequisite and activate the
> > platform by default.
> > 
> > Signed-off-by: Aditya Chauhan <aditya.chauhan@xxxxxxxxx>
> > Signed-off-by: Andrzej Hajda <andrzej.hajda@xxxxxxxxx>
> > Signed-off-by: Chris Wilson <chris.p.wilson@xxxxxxxxxxxxxxx>
> > Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik@xxxxxxxxxxxxxxx>
> > Signed-off-by: Jonathan Cavitt <jonathan.cavitt@xxxxxxxxx>
> > Signed-off-by: Nirmoy Das <nirmoy.das@xxxxxxxxx>
> > Signed-off-by: Radhakrishna Sripada <radhakrishna.sripada@xxxxxxxxx>
> > Signed-off-by: Andi Shyti <andi.shyti@xxxxxxxxxxxxxxx>
> > Cc: Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx>
> > Cc: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>
> > Cc: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>
> > Cc: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
> > ---
> > Hello,
> > 
> > This patch eliminates the 'force probe' for the MTL platforms. Over the recent
> > weeks, MTL has demonstrated stability, consistently passing BAT tests with
> > success rates ranging from 98% to 100%.
> > 
> > There's a single issue hindering us from achieving a 100% BAT test coverage.
> > Fortunately, we've identified the issue, and the proposed solution can be found
> > here[*]. The CI results are encouraging.
> > 
> > Once all reviews are addressed, we plan to submit this series with the "Fixes:"
> > tag.
> > 
> > Thank you and best regards,
> > Andi and Radhakrishna
> > 
> > [*] https://patchwork.freedesktop.org/series/124744/
> > 
> >  drivers/gpu/drm/i915/i915_pci.c | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
> > index df7c261410f7..fe748906c06f 100644
> > --- a/drivers/gpu/drm/i915/i915_pci.c
> > +++ b/drivers/gpu/drm/i915/i915_pci.c
> > @@ -836,7 +836,6 @@  static const struct intel_device_info mtl_info = {
> >  	.has_pxp = 1,
> >  	.memory_regions = REGION_SMEM | REGION_STOLEN_LMEM,
> >  	.platform_engine_mask = BIT(RCS0) | BIT(BCS0) | BIT(CCS0),
> > -	.require_force_probe = 1,
> >  	MTL_CACHELEVEL,
> >  };
> >  
> 
> Test on my MTL device and it works properly.
> 
> Acked-by: Lee Shawn C <shawn.c.lee@xxxxxxxxx>
> Tested-by: Lee Shawn C <shawn.c.lee@xxxxxxxxx>

Thanks a lot for your ack!

In your original mail[*] the "Reply-To" and the "In-Reply-To"
fields were swapped. I fixed it and added the correct Cc chain.

Thanks,
Andi

[*] https://lore.kernel.org/intel-gfx/BYAPR11MB27101EF88CCBDBA430108CD5A3CCA@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/



[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux