== Series Details == Series: drm/i915: Start cleaning up the DPLL ID mess (rev3) URL : https://patchwork.freedesktop.org/series/108827/ State : warning == Summary == Error: dim checkpatch failed af48f78e0453 drm/i915: Stop requiring PLL index == PLL ID -:184: CHECK:SPACING: No space is necessary after a cast #184: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:577: + id = (enum intel_dpll_id) crtc->pipe; total: 0 errors, 0 warnings, 1 checks, 200 lines checked cc7c89728d27 drm/i915: Decouple I915_NUM_PLLS from PLL IDs 231a873e02f7 drm/i915: Introduce for_each_shared_dpll() -:162: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i915' - possible side-effects? #162: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.h:32: +#define for_each_shared_dpll(__i915, __pll, __i) \ + for ((__i) = 0; (__i) < (__i915)->display.dpll.num_shared_dpll && \ + ((__pll) = &(__i915)->display.dpll.shared_dplls[(__i)]) ; (__i)++) -:162: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i' - possible side-effects? #162: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.h:32: +#define for_each_shared_dpll(__i915, __pll, __i) \ + for ((__i) = 0; (__i) < (__i915)->display.dpll.num_shared_dpll && \ + ((__pll) = &(__i915)->display.dpll.shared_dplls[(__i)]) ; (__i)++) total: 0 errors, 0 warnings, 2 checks, 142 lines checked 8e9c1c226f27 drm/i915: s/dev_priv/i915/ in the shared_dpll code -:103: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!pll" #103: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:236: + if (drm_WARN_ON(&i915->drm, pll == NULL)) -:774: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #774: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:1941: +static void bxt_ddi_pll_enable(struct drm_i915_private *i915, struct intel_shared_dpll *pll) -:906: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #906: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:2042: +static void bxt_ddi_pll_disable(struct drm_i915_private *i915, struct intel_shared_dpll *pll) -:932: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #932: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:2061: +static bool bxt_ddi_pll_get_hw_state(struct drm_i915_private *i915, struct intel_shared_dpll *pll, total: 0 errors, 0 warnings, 4 checks, 2142 lines checked
