Quoting Jani Nikula (2023-10-02 05:47:02-03:00)
>Have to give up the const on i915 pointer, but it's not big of a deal
What if patch #2 ("drm/i915: allocate i915->gt0 dynamically") was the first in
the series? I see it changes to_gt() to receive a const struct drm_i915_private
*i915.
Either way,
Reviewed-by: Gustavo Sousa <gustavo.sousa@xxxxxxxxx>
>considering non-const i915 gets passed all over the place.
>
>Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx>
>---
> drivers/gpu/drm/i915/gt/intel_mocs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/gt/intel_mocs.c b/drivers/gpu/drm/i915/gt/intel_mocs.c
>index 07269ff3be13..353f93baaca0 100644
>--- a/drivers/gpu/drm/i915/gt/intel_mocs.c
>+++ b/drivers/gpu/drm/i915/gt/intel_mocs.c
>@@ -487,7 +487,7 @@ static bool has_mocs(const struct drm_i915_private *i915)
> return !IS_DGFX(i915);
> }
>
>-static unsigned int get_mocs_settings(const struct drm_i915_private *i915,
>+static unsigned int get_mocs_settings(struct drm_i915_private *i915,
> struct drm_i915_mocs_table *table)
> {
> unsigned int flags;
>@@ -495,7 +495,7 @@ static unsigned int get_mocs_settings(const struct drm_i915_private *i915,
> memset(table, 0, sizeof(struct drm_i915_mocs_table));
>
> table->unused_entries_index = I915_MOCS_PTE;
>- if (IS_GFX_GT_IP_RANGE(&i915->gt0, IP_VER(12, 70), IP_VER(12, 71))) {
>+ if (IS_GFX_GT_IP_RANGE(to_gt(i915), IP_VER(12, 70), IP_VER(12, 71))) {
> table->size = ARRAY_SIZE(mtl_mocs_table);
> table->table = mtl_mocs_table;
> table->n_entries = MTL_NUM_MOCS_ENTRIES;
>--
>2.39.2
>
