== Series Details == Series: Update GGTT with MI_UPDATE_GTT on MTL (rev11) URL : https://patchwork.freedesktop.org/series/123329/ State : warning == Summary == Error: dim checkpatch failed 515de5f4d67c drm/i915: Lift runtime-pm acquire callbacks out of intel_wakeref.mutex -:66: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants #66: FILE: drivers/gpu/drm/i915/intel_wakeref.c:28: + INTEL_WAKEREF_BUG_ON(wf->wakeref); -:81: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants #81: FILE: drivers/gpu/drm/i915/intel_wakeref.c:43: + INTEL_WAKEREF_BUG_ON(atomic_read(&wf->count) <= 0); -:104: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants #104: FILE: drivers/gpu/drm/i915/intel_wakeref.c:63: + INTEL_WAKEREF_BUG_ON(!wf->wakeref); total: 0 errors, 3 warnings, 0 checks, 89 lines checked 1e0df52d355f drm/i915: Create a kernel context for GGTT updates -:111: CHECK:LINE_SPACING: Please don't use multiple blank lines #111: FILE: drivers/gpu/drm/i915/gt/intel_engine_cs.c:1573: + + total: 0 errors, 0 warnings, 1 checks, 149 lines checked b31ee3d30924 drm/i915: Implement for_each_sgt_daddr_next -:41: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__iter' - possible side-effects? #41: FILE: drivers/gpu/drm/i915/i915_scatterlist.h:100: +#define __for_each_daddr_next(__dp, __iter, __step) \ + for (; ((__dp) = (__iter).dma + (__iter).curr), (__iter).sgp; \ + (((__iter).curr += (__step)) >= (__iter).max) ? \ + (__iter) = __sgt_iter(__sg_next((__iter).sgp), true), 0 : 0) total: 0 errors, 0 warnings, 1 checks, 25 lines checked 1b28bfa93783 drm/i915: Parameterize binder context creation de8e6aa49f51 drm/i915: Implement GGTT update method with MI_UPDATE_GTT -:70: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants #70: FILE: drivers/gpu/drm/i915/gt/intel_ggtt.c:276: + GEM_BUG_ON(!ce); -:240: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #240: FILE: drivers/gpu/drm/i915/gt/intel_ggtt.c:491: + if (!gen8_ggtt_bind_ptes(ggtt, start, vma_res->bi.pages, + vma_res->node_size / I915_GTT_PAGE_SIZE, pte_encode)) -:288: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #288: FILE: drivers/gpu/drm/i915/gt/intel_ggtt.c:553: + if (should_update_ggtt_with_bind(ggtt) && gen8_ggtt_bind_ptes(ggtt, first_entry, + NULL, num_entries, scratch_pte)) total: 0 errors, 1 warnings, 2 checks, 283 lines checked af18f2d0b7f4 drm/i915: Toggle binder context ready status 2a1215677e13 drm/i915: Enable GGTT updates with binder in MTL