On Tue, Sep 26, 2023 at 12:34:35PM +0300, Jani Nikula wrote: > On Tue, 26 Sep 2023, "Manna, Animesh" <animesh.manna@xxxxxxxxx> wrote: > >> -----Original Message----- > >> From: Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx> > >> Sent: Monday, September 25, 2023 6:00 PM > >> To: Manna, Animesh <animesh.manna@xxxxxxxxx>; intel- > >> gfx@xxxxxxxxxxxxxxxxxxxxx > >> Subject: Re: [PATCH] drm/i915/dsb: DSB code refactoring > >> > >> On Sat, 23 Sep 2023, Animesh Manna <animesh.manna@xxxxxxxxx> wrote: > >> > Refactor DSB implementation to be compatible with Xe driver. > >> > >> Sad trombone. > >> > >> struct intel_dsb should remain an opaque type. I put effort into hiding its > >> definition, so its guts wouldn't be accessed nilly-willy all over the place. If it's > >> not hidden, it just will get accessed. > > > > Hi Jani, > > > > Xe driver need access to intel_dsb structure, so I can create a new header file intel_dsb_ops.h and keep intel_dsb structure in it. Is it ok? > > I just think you need to find a different abstraction level that doesn't > involve exposing struct intel_dsb. I hate the fact that we seem to be adding these ad-hoc wrappers all over the place. Someone should just fix xe to give us the same API as i915, or a single wrapper should do whatever conversion is needed. -- Ville Syrjälä Intel
