Re: [PATCH 1/3] drm/i915: Introduce intel_gt_mcr_lock_reset()

[Andi Shyti <andi.shyti@xxxxxxxxxxxxxxx>]

Hi Nirmoy,

[...]

> +void intel_gt_mcr_lock_reset(struct intel_gt *gt)
> +{
> +	unsigned long __flags;
> +
> +	lockdep_assert_not_held(&gt->uncore->lock);
> +
> +	spin_lock_irqsave(&gt->mcr_lock, __flags);
> +
> +	if (GRAPHICS_VER_FULL(gt->i915) >= IP_VER(12, 70))
> +		intel_uncore_write_fw(gt->uncore, MTL_STEER_SEMAPHORE, 0x1);
> +
> +	spin_unlock_irqrestore(&gt->mcr_lock, __flags);

As we discussed offline, I don't think spinlocks are needed here.
I don't expect the gt to be holding the lock somewhere else.

Andi

> +}