On Sun, Sep 24, 2023 at 12:41:07AM +0000, Dr. David Alan Gilbert wrote: > Hi, > I randomly noticed there are a couple of places in the kernel that > do > ERR_PTR(0); > > and thought that was odd - shouldn't those just be NULL's ? > > 1) i915 > drivers/gpu/drm/i915/gt/uc/selftest_guc_multi_lrc.c : 47 > > if (i <= 1) > return ERR_PTR(0); Yes, s/ERR_PTR(0)/ERR_PTR(NULL)/ Matt > > from f9d72092cb490 > > 2) trf7970a > drivers/nfc/trf7970a.c : 896 > > trf->ignore_timeout = > !cancel_delayed_work(&trf->timeout_work); > trf->rx_skb = ERR_PTR(0); > trf7970a_send_upstream(trf); > > from 1961843ceeca0 > > Dave > -- > -----Open up your eyes, open up your mind, open up your code ------- > / Dr. David Alan Gilbert | Running GNU/Linux | Happy \ > \ dave @ treblig.org | | In Hex / > \ _________________________|_____ http://www.treblig.org |_______/