Re: [PATCH] drm/i915/gt: remove a static inline that requires including i915_drv.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jani,

On Thu, Sep 21, 2023 at 07:24:56PM +0300, Jani Nikula wrote:
> It's actively harmful to add static inlines in headers that require you
> to pull in more headers. Remove the include added in commit f1530f912ed8
> ("drm/i915/gt: Apply workaround 22016122933 correctly"). We see that
> there's already an implicit dependency on the i915_drv.h that we need to
> address too.
> 
> Cc: Andi Shyti <andi.shyti@xxxxxxxxxxxxxxx>
> Cc: Fei Yang <fei.yang@xxxxxxxxx>
> Cc: Jonathan Cavitt <jonathan.cavitt@xxxxxxxxx>
> Cc: Matt Roper <matthew.d.roper@xxxxxxxxx>
> Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx>

Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxxxxxxxx> 

Andi



[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux