On Wed, 20 Sep 2023, Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> wrote:
> On Wed, Sep 20, 2023 at 02:29:01PM +0300, Jani Nikula wrote:
>> Add a note that fec_enable actually means FEC is to be enabled
>> explicitly. 128b/132b always has FEC enabled, the driver doesn't need to
>> enable it separately, and fec_enable will be false.
>>
>> Cc: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
>> Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx>
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
Thanks, pushed.
BR,
Jani
>
>> ---
>> drivers/gpu/drm/i915/display/intel_display_types.h | 7 ++++++-
>> 1 file changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
>> index 3c54fe2bfddd..f781a9755a52 100644
>> --- a/drivers/gpu/drm/i915/display/intel_display_types.h
>> +++ b/drivers/gpu/drm/i915/display/intel_display_types.h
>> @@ -1364,7 +1364,12 @@ struct intel_crtc_state {
>>
>> bool enhanced_framing;
>>
>> - /* Forward Error correction State */
>> + /*
>> + * Forward Error Correction.
>> + *
>> + * Note: This will be false for 128b/132b, which will always have FEC
>> + * enabled automatically.
>> + */
>> bool fec_enable;
>>
>> bool sdp_split_enable;
>> --
>> 2.39.2
--
Jani Nikula, Intel
