On Thu, Sep 19, 2013 at 07:18:54PM -0300, Paulo Zanoni wrote: > 2013/9/16 <ville.syrjala@xxxxxxxxxxxxxxx>: > > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > > > Call intel_uncore_early_sanitize() first thing during resume to prevent > > stale BIOS leftovers from being reported as unclaimed register access. > > Just out of curiosity: do you actually need this patch to avoid error > messages? The change makes sense, but since we didn't need it so far, > I wonder if maybe it's something we're doing wrong that's causing the > need to sanitize. It does get rid of an error message on my HSW machine during hibernate. I just noticed that I didn't have CONFIG_SND_HDA_I915 enabled, but I just tried to enable it and I still got the error. The latest BIOS didn't fix it either. And I also tried to clear the error as the last thing before we suspend the device, and that didn't help either. So it does look like the BIOS does something silly. > > Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > --- > > drivers/gpu/drm/i915/i915_drv.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c > > index fdf3eef..3d25731 100644 > > --- a/drivers/gpu/drm/i915/i915_drv.c > > +++ b/drivers/gpu/drm/i915/i915_drv.c > > @@ -670,6 +670,8 @@ int i915_resume(struct drm_device *dev) > > > > pci_set_master(dev->pdev); > > > > + intel_uncore_early_sanitize(dev); > > + > > intel_uncore_sanitize(dev); > > > > /* > > -- > > 1.8.1.5 > > > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > > http://lists.freedesktop.org/mailman/listinfo/intel-gfx > > > > -- > Paulo Zanoni -- Ville Syrjälä Intel OTC _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
