Re: [PATCH 10/11] drm/i915: Call intel_uncore_early_sanitize() during resume

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2013/9/16  <ville.syrjala@xxxxxxxxxxxxxxx>:
> From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
>
> Call intel_uncore_early_sanitize() first thing during resume to prevent
> stale BIOS leftovers from being reported as unclaimed register access.

Just out of curiosity: do you actually need this patch to avoid error
messages? The change makes sense, but since we didn't need it so far,
I wonder if maybe it's something we're doing wrong that's causing the
need to sanitize.


>
> Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
> ---
>  drivers/gpu/drm/i915/i915_drv.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index fdf3eef..3d25731 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -670,6 +670,8 @@ int i915_resume(struct drm_device *dev)
>
>         pci_set_master(dev->pdev);
>
> +       intel_uncore_early_sanitize(dev);
> +
>         intel_uncore_sanitize(dev);
>
>         /*
> --
> 1.8.1.5
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx



-- 
Paulo Zanoni
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx





[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux