On Tue, Sep 19, 2023 at 04:12:46PM -0000, Patchwork wrote:
> -:7: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
> #7:
> > Andrzej asked me to try to revert commits 0b62af28f249, e0b72c14d8dc and 1e0877d58b1e, and reverting those fixed the i915 crash for me. The e0b72c14d8dc and 1e0877d58b1e commits look like just prerequisites, so I assume 0b62af28f249 ("i915: convert shmem_sg_free_table() to use a folio_batch") is the culprit here.
This is just a parsing fail.
> -:48: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
> #48: FILE: drivers/gpu/drm/i915/gem/i915_gem_shmem.c:155:
> + nr_pages = min_t(unsigned long,
> + folio_nr_pages(folio), page_count - i);
This is bullshit. Aligning to open paren is an antipattern that leads
to significant unnecessary code churn. I will not be part of such a
stupid system.
