> -----Original Message----- > From: Intel-gfx <intel-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Ville > Syrjala > Sent: 01 September 2023 18:35 > To: intel-gfx@xxxxxxxxxxxxxxxxxxxxx > Subject: [PATCH 08/12] drm/i915: Validate that the timings are > within the VRR range > > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > Let's assume there are some crazy displays where the high end of the VRR > range ends up being lower than the refresh rate as determined by the actual > timings. In that case when we toggle VRR on/off we would step outside the > VRR range when toggling VRR on/off. Let's just make sure that never happens > by not using VRR in such cases. If the user really wants VRR they should then > select the timings to land within the VRR range. > > Cc: Manasi Navare <navaremanasi@xxxxxxxxxxxx> > Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > --- > drivers/gpu/drm/i915/display/intel_vrr.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_vrr.c > b/drivers/gpu/drm/i915/display/intel_vrr.c > index 6ef782538337..12731ad725a8 100644 > --- a/drivers/gpu/drm/i915/display/intel_vrr.c > +++ b/drivers/gpu/drm/i915/display/intel_vrr.c > @@ -117,10 +117,10 @@ intel_vrr_compute_config(struct intel_crtc_state > *crtc_state, > const struct drm_display_info *info = &connector- > >base.display_info; > int vmin, vmax; > > - if (!intel_vrr_is_capable(connector)) > + if (adjusted_mode->flags & DRM_MODE_FLAG_INTERLACE) > return; > > - if (adjusted_mode->flags & DRM_MODE_FLAG_INTERLACE) > + if (!intel_vrr_is_in_range(connector, > +drm_mode_vrefresh(adjusted_mode))) Changes LGTM Reviewed-by: Mitul Golani <mitulkumar.ajitkumar.golani@xxxxxxxxx> Regards, Mitul > return; > > vmin = DIV_ROUND_UP(adjusted_mode->crtc_clock * 1000, > -- > 2.41.0
