== Series Details == Series: Update GGTT with MI_UPDATE_GTT on MTL (rev3) URL : https://patchwork.freedesktop.org/series/123329/ State : warning == Summary == Error: dim checkpatch failed 9cea16eb6ab8 drm/i915: Lift runtime-pm acquire callbacks out of intel_wakeref.mutex -:57: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants #57: FILE: drivers/gpu/drm/i915/intel_wakeref.c:27: + INTEL_WAKEREF_BUG_ON(wf->wakeref); -:73: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants #73: FILE: drivers/gpu/drm/i915/intel_wakeref.c:40: + INTEL_WAKEREF_BUG_ON(atomic_read(&wf->count) <= 0); -:96: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants #96: FILE: drivers/gpu/drm/i915/intel_wakeref.c:60: + INTEL_WAKEREF_BUG_ON(!wf->wakeref); total: 0 errors, 3 warnings, 0 checks, 83 lines checked 01aae02e63b3 drm/i915: Create a kernel context for GGTT updates 1c7cfec1dc08 drm/i915: Implement __for_each_sgt_daddr_next -:25: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__iter' - possible side-effects? #25: FILE: drivers/gpu/drm/i915/i915_scatterlist.h:100: +#define __for_each_daddr_next(__dp, __iter, __step) \ + for (; ((__dp) = (__iter).dma + (__iter).curr), (__iter).sgp; \ + (((__iter).curr += (__step)) >= (__iter).max) ? \ + (__iter) = __sgt_iter(__sg_next((__iter).sgp), true), 0 : 0) total: 0 errors, 0 warnings, 1 checks, 16 lines checked 61dbf734f8c7 drm/i915: Implement GGTT update method with MI_UPDATE_GTT -:68: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants #68: FILE: drivers/gpu/drm/i915/gt/intel_ggtt.c:276: + GEM_BUG_ON(!ce); -:238: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #238: FILE: drivers/gpu/drm/i915/gt/intel_ggtt.c:491: + if (!gen8_ggtt_bind_ptes(ggtt, start, vma_res->bi.pages, + vma_res->node_size / I915_GTT_PAGE_SIZE, pte_encode)) -:286: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #286: FILE: drivers/gpu/drm/i915/gt/intel_ggtt.c:553: + if (should_update_ggtt_with_bind(ggtt) && gen8_ggtt_bind_ptes(ggtt, first_entry, + NULL, num_entries, scratch_pte)) total: 0 errors, 1 warnings, 2 checks, 292 lines checked 48c23376d051 drm/i915: Enable GGTT updates with binder in MTL
