Hi Animesh, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Animesh-Manna/drm-panelreplay-dpcd-register-definition-for-panelreplay/20230824-122224 base: git://anongit.freedesktop.org/drm/drm-tip drm-tip patch link: https://lore.kernel.org/r/20230824040952.186407-5-animesh.manna%40intel.com patch subject: [PATCH v4 4/6] drm/i915/panelreplay: Initializaton and compute config for panel replay config: x86_64-rhel-8.3-rust (https://download.01.org/0day-ci/archive/20230826/202308260901.MphIjr2l-lkp@xxxxxxxxx/config) compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project.git 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a) reproduce: (https://download.01.org/0day-ci/archive/20230826/202308260901.MphIjr2l-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202308260901.MphIjr2l-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): >> drivers/gpu/drm/i915/display/intel_dp.c:3776:27: warning: overlapping comparisons always evaluate to true [-Wtautological-overlap-compare] if (vsc->revision != 0x5 || vsc->revision != 0x7) ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~ 1 warning generated. vim +3776 drivers/gpu/drm/i915/display/intel_dp.c 3751 3752 static ssize_t intel_dp_vsc_sdp_pack(const struct drm_dp_vsc_sdp *vsc, 3753 struct dp_sdp *sdp, size_t size) 3754 { 3755 size_t length = sizeof(struct dp_sdp); 3756 3757 if (size < length) 3758 return -ENOSPC; 3759 3760 memset(sdp, 0, size); 3761 3762 /* 3763 * Prepare VSC Header for SU as per DP 1.4a spec, Table 2-119 3764 * VSC SDP Header Bytes 3765 */ 3766 sdp->sdp_header.HB0 = 0; /* Secondary-Data Packet ID = 0 */ 3767 sdp->sdp_header.HB1 = vsc->sdp_type; /* Secondary-data Packet Type */ 3768 sdp->sdp_header.HB2 = vsc->revision; /* Revision Number */ 3769 sdp->sdp_header.HB3 = vsc->length; /* Number of Valid Data Bytes */ 3770 3771 /* 3772 * Other than revision 0x5 which supports Pixel Encoding/Colorimetry 3773 * Format as per DP 1.4a spec, revision 0x7 also supports Pixel 3774 * Encoding/Colorimetry Format as per DP 2.0 spec. 3775 */ > 3776 if (vsc->revision != 0x5 || vsc->revision != 0x7) 3777 goto out; 3778 3779 /* VSC SDP Payload for DB16 through DB18 */ 3780 /* Pixel Encoding and Colorimetry Formats */ 3781 sdp->db[16] = (vsc->pixelformat & 0xf) << 4; /* DB16[7:4] */ 3782 sdp->db[16] |= vsc->colorimetry & 0xf; /* DB16[3:0] */ 3783 3784 switch (vsc->bpc) { 3785 case 6: 3786 /* 6bpc: 0x0 */ 3787 break; 3788 case 8: 3789 sdp->db[17] = 0x1; /* DB17[3:0] */ 3790 break; 3791 case 10: 3792 sdp->db[17] = 0x2; 3793 break; 3794 case 12: 3795 sdp->db[17] = 0x3; 3796 break; 3797 case 16: 3798 sdp->db[17] = 0x4; 3799 break; 3800 default: 3801 MISSING_CASE(vsc->bpc); 3802 break; 3803 } 3804 /* Dynamic Range and Component Bit Depth */ 3805 if (vsc->dynamic_range == DP_DYNAMIC_RANGE_CTA) 3806 sdp->db[17] |= 0x80; /* DB17[7] */ 3807 3808 /* Content Type */ 3809 sdp->db[18] = vsc->content_type & 0x7; 3810 3811 out: 3812 return length; 3813 } 3814 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
