Hi Jonathan, > + /* Wa_16018031267, Wa_16018063123 */ > + if (engine->class == COPY_ENGINE_CLASS && > + NEEDS_FASTCOLOR_BLT_WABB(i915)) maybe we should have something like gt_needs_wa_XXX(struct intel_gt *gt) engine_needs_wa_XXX(struct intel_engine_ce *engine) Just thinking aloud here, not relevant to this series. Andi > + wa_masked_field_set(wal, ECOSKPD(engine->mmio_base), > + XEHP_BLITTER_SCHEDULING_MODE_MASK, > + XEHP_BLITTER_ROUND_ROBIN_MODE); > } > > static void > -- > 2.25.1