== Series Details == Series: Apply Wa_16018031267 / Wa_16018063123 (rev2) URL : https://patchwork.freedesktop.org/series/122804/ State : warning == Summary == Error: dim checkpatch failed 00f4bda3e3b0 drm/i915: Add WABB blit for Wa_16018031267 / Wa_16018063123 -:11: WARNING:BAD_SIGN_OFF: Co-developed-by: should not be used to attribute nominal patch author 'Nirmoy Das <nirmoy.das@xxxxxxxxx>' #11: Co-developed-by: Nirmoy Das <nirmoy.das@xxxxxxxxx> -:11: WARNING:BAD_SIGN_OFF: Co-developed-by: must be immediately followed by Signed-off-by: #11: Co-developed-by: Nirmoy Das <nirmoy.das@xxxxxxxxx> -:54: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants #54: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:836: + GEM_BUG_ON(lrc_ring_wa_bb_per_ctx(engine) == -1); -:74: WARNING:SPACE_BEFORE_TAB: please, no space before tabs #74: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:1017: + * ^I^Ithe PER_CTX_BB. When disabled, the function returns$ -:75: WARNING:SPACE_BEFORE_TAB: please, no space before tabs #75: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:1018: + * ^I^Ithe location of the INDIRECT_CTX.$ -:110: ERROR:TRAILING_WHITESPACE: trailing whitespace #110: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:1402: +^Iu32 addr = intel_gt_scratch_offset(gt, INTEL_GT_SCRATCH_FIELD_DUMMY_BLIT); $ -:164: CHECK:LINE_SPACING: Please don't use multiple blank lines #164: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:1456: + + -:180: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants #180: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:1472: + GEM_BUG_ON(cs - start > I915_GTT_PAGE_SIZE / sizeof(*cs)); -:225: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #225: FILE: drivers/gpu/drm/i915/gt/selftest_lrc.c:1583: +emit_wabb_ctx_canary(const struct intel_context *ce, + u32 *cs, bool per_ctx) -:250: ERROR:CODE_INDENT: code indent should use tabs where possible #250: FILE: drivers/gpu/drm/i915/gt/selftest_lrc.c:1607: + return emit_wabb_ctx_canary(ce, cs, true);$ -:250: WARNING:LEADING_SPACE: please, no spaces at the start of a line #250: FILE: drivers/gpu/drm/i915/gt/selftest_lrc.c:1607: + return emit_wabb_ctx_canary(ce, cs, true);$ -:354: ERROR:TRAILING_WHITESPACE: trailing whitespace #354: FILE: drivers/gpu/drm/i915/gt/selftest_lrc.c:1739: +}^I^I$ -:375: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #375: FILE: drivers/gpu/drm/i915/i915_drv.h:816: +#define NEEDS_FASTCOLOR_BLT_WABB(i915) (GRAPHICS_VER_FULL(i915) == IP_VER(12, 70) || \ + GRAPHICS_VER_FULL(i915) == IP_VER(12, 71) || \ + IS_PONTEVECCHIO(i915) || \ + IS_DG2(i915)) -:380: ERROR:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Nirmoy Das <nirmoy.das@xxxxxxxxx>' total: 4 errors, 7 warnings, 3 checks, 330 lines checked 506e01dfa9cc drm/i915: Set copy engine arbitration for Wa_16018031267 / Wa_16018063123