Hi Jonathan, > > The hangcheck live selftest contains duplicate declarations of some > > functions that already exist in igt_spinner.c, such as the creation and > > deconstruction of a spinning batch buffer (spinner) that hangs an engine. > > It's undesireable to have such code duplicated, as the requirements for > > the spinner may change with hardware updates, necessitating both > > execution paths be updated. To avoid this, have the hangcheck live > > selftest use the declaration from igt_spinner. This eliminates the need > > for the declarations in the selftest itself, as well as the associated > > local helper structures, so we can erase those. > > > > Suggested-by: Matt Roper <matthew.d.roper@xxxxxxxxx> > > Signed-off-by: Jonathan Cavitt <jonathan.cavitt@xxxxxxxxx> > > > Test fails with -62 (ETIME) on intel_selftest_wait_for_rq > It looks like the cause might be me calling intel_context_put too early? > Let me move those calls to later and see if that helps. > Give me some time to implement those changes. Thanks! Andi
