Re: [PATCH 3/3] drm/i915/display: Add wrapper to Compute SAD

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Mitul,

kernel test robot noticed the following build warnings:

[auto build test WARNING on drm-tip/drm-tip]

url:    https://github.com/intel-lab-lkp/linux/commits/Mitul-Golani/drm-i915-Add-has_audio-to-separate-audio-parameter-in-crtc_state/20230817-205556
base:   git://anongit.freedesktop.org/drm/drm-tip drm-tip
patch link:    https://lore.kernel.org/r/20230817125007.2681331-4-mitulkumar.ajitkumar.golani%40intel.com
patch subject:  [PATCH 3/3] drm/i915/display: Add wrapper to Compute SAD
config: x86_64-buildonly-randconfig-r001-20230817 (https://download.01.org/0day-ci/archive/20230817/202308172319.rTgU3hnc-lkp@xxxxxxxxx/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce: (https://download.01.org/0day-ci/archive/20230817/202308172319.rTgU3hnc-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308172319.rTgU3hnc-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/i915/display/intel_audio.c:822:39: warning: variable 'channel_count' is uninitialized when used here [-Wuninitialized]
                   audio_req_bandwidth = calc_audio_bw(channel_count,
                                                       ^~~~~~~~~~~~~
   drivers/gpu/drm/i915/display/intel_audio.c:812:19: note: initialize the variable 'channel_count' to silence this warning
           int channel_count;
                            ^
                             = 0
   1 warning generated.


vim +/channel_count +822 drivers/gpu/drm/i915/display/intel_audio.c

   808	
   809	static void calibrate_audio_config_params(struct intel_crtc_state *pipe_config, int channel)
   810	{
   811		struct drm_display_mode *adjusted_mode = &pipe_config->hw.adjusted_mode;
   812		int channel_count;
   813		int index, rate[] = { 192000, 176000, 96000, 88000, 48000, 44100, 32000 };
   814		int audio_req_bandwidth, available_blank_bandwidth, vblank, hblank;
   815	
   816		hblank = adjusted_mode->htotal - adjusted_mode->hdisplay;
   817		vblank = adjusted_mode->vtotal - adjusted_mode->vdisplay;
   818		available_blank_bandwidth = hblank * vblank *
   819					    drm_mode_vrefresh(adjusted_mode) * pipe_config->pipe_bpp;
   820	
   821		for (index = 0; index < ARRAY_SIZE(rate); index++) {
 > 822			audio_req_bandwidth = calc_audio_bw(channel_count,
   823							    rate[index]);
   824			if (audio_req_bandwidth < available_blank_bandwidth) {
   825				pipe_config->audio.max_rate = rate[index];
   826				pipe_config->audio.max_channel_count = channel_count;
   827				return;
   828			}
   829		}
   830	
   831		pipe_config->audio.max_rate = 0;
   832		pipe_config->audio.max_channel_count = 0;
   833	}
   834	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki



[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux