On Wed, 2023-08-16 at 08:13 +0000, Kandpal, Suraj wrote: > > This function doesn't really return the pin assignment mask, but > > the max lane > > count derived from that. So rename the function to > > mtl_tc_port_get_max_lane_count() to better reflect what it really > > does. > > > Maybe also add the version changes on commit messages here as cover > letter ends up getting discarded Ah, right. I discussed this with someone else before and we agreed to disagree. 🙂 I don't really see the point in having the change history in the commit itself for the mainline. The discussions should be openly available in the mailing list archives, so duplicating it in the commit logs, IMHO, is moot. A link in the commit log to lore, for instance, would add much more value IMHO. But anyway, since this guideline was already in place when I came, I will (almost grudgingly) comply. 😉 > > With that fixed > > Reviewed-by: Suraj Kandpal <suraj.kandpal@xxxxxxxxx> Thanks! -- Cheers, Luca.
