On Mon, Aug 07, 2023, Like Xu wrote:
> On 23/12/2022 8:57 am, Sean Christopherson wrote:
> > +static inline void kvm_page_track_write(struct kvm_vcpu *vcpu, gpa_t gpa,
> > + const u8 *new, int bytes)
> > +{
> > + __kvm_page_track_write(vcpu, gpa, new, bytes);
> > +
> > + kvm_mmu_track_write(vcpu, gpa, new, bytes);
> > +}
>
> The kvm_mmu_track_write() is only used for x86, where the incoming parameter
> "u8 *new" has not been required since 0e0fee5c539b ("kvm: mmu: Fix race in
> emulated page table writes"), please help confirm if it's still needed ? Thanks.
> A minor clean up is proposed.
Hmm, unless I'm misreading things, KVMGT ultimately doesn't consume @new either.
So I think we can remove @new from kvm_page_track_write() entirely.
Feel free to send a patch, otherwise I'll get to it later this week.
