On Wed, 26 Jul 2023, Patchwork <patchwork@xxxxxxxxxxxxxxxxxxxxxx> wrote: > == Series Details == > > Series: Replace acronym with full platform name in defines. > URL : https://patchwork.freedesktop.org/series/121387/ > State : warning > > == Summary == > > Error: dim checkpatch failed All the parenthesis alignments warnings are valid. BR, Jani. > b0b6ca2cb60d drm/i915/jsl: s/JSL/JASPERLAKE for platform/subplatform defines > -:38: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis > #38: FILE: drivers/gpu/drm/i915/display/icl_dsi.c:448: > + if (IS_JASPERLAKE(dev_priv) || IS_ELKHARTLAKE(dev_priv) || > + (DISPLAY_VER(dev_priv) >= 12)) { > > -:101: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis > #101: FILE: drivers/gpu/drm/i915/display/intel_combo_phy.c:337: > + if ((IS_JASPERLAKE(dev_priv) || IS_ELKHARTLAKE(dev_priv)) && > + phy == PHY_A) { > > -:115: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis > #115: FILE: drivers/gpu/drm/i915/display/intel_ddi.c:3587: > + else if ((IS_JASPERLAKE(dev_priv) || IS_ELKHARTLAKE(dev_priv)) && > + crtc_state->port_clock > 594000) > > -:156: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis > #156: FILE: drivers/gpu/drm/i915/display/intel_display.c:1805: > + else if ((IS_JASPERLAKE(i915) || IS_ELKHARTLAKE(i915)) && > + port == PORT_D) > > -:183: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis > #183: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:195: > + else if ((IS_JASPERLAKE(i915) || IS_ELKHARTLAKE(i915)) && > + (pll->info->id == DPLL_ID_EHL_DPLL4)) > > -:214: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis > #214: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:3573: > + if ((IS_JASPERLAKE(dev_priv) || IS_ELKHARTLAKE(dev_priv)) && > + id == DPLL_ID_EHL_DPLL4) { > > -:224: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis > #224: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:3630: > + if ((IS_JASPERLAKE(dev_priv) || IS_ELKHARTLAKE(dev_priv)) && > + id == DPLL_ID_EHL_DPLL4) { > > -:235: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis > #235: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:3814: > + if ((IS_JASPERLAKE(dev_priv) || IS_ELKHARTLAKE(dev_priv)) && > + pll->info->id == DPLL_ID_EHL_DPLL4) { > > -:246: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis > #246: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:3922: > + if ((IS_JASPERLAKE(dev_priv) || IS_ELKHARTLAKE(dev_priv)) && > + pll->info->id == DPLL_ID_EHL_DPLL4) > > -:265: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis > #265: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:4343: > + if ((IS_JASPERLAKE(i915) || IS_ELKHARTLAKE(i915)) && > + pll->on && > > -:279: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis > #279: FILE: drivers/gpu/drm/i915/display/intel_hdmi.c:2898: > + else if ((IS_JASPERLAKE(dev_priv) || IS_ELKHARTLAKE(dev_priv)) && > + HAS_PCH_TGP(dev_priv)) > > -:385: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis > #385: FILE: drivers/gpu/drm/i915/soc/intel_pch.c:119: > + drm_WARN_ON(&dev_priv->drm, !(IS_JASPERLAKE(dev_priv) || > + IS_ELKHARTLAKE(dev_priv))); > > -:395: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis > #395: FILE: drivers/gpu/drm/i915/soc/intel_pch.c:132: > + drm_WARN_ON(&dev_priv->drm, !(IS_JASPERLAKE(dev_priv) || > + IS_ELKHARTLAKE(dev_priv))); > > total: 0 errors, 0 warnings, 13 checks, 287 lines checked -- Jani Nikula, Intel Open Source Graphics Center