Re: [PATCH 4/4] drm/i915/tc: remove "fia" from intel_tc_port_fia_max_lane_count()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Luca,

kernel test robot noticed the following build errors:

[auto build test ERROR on drm-tip/drm-tip]

url:    https://github.com/intel-lab-lkp/linux/commits/Luca-Coelho/drm-i915-tc-rename-mtl_tc_port_get_pin_assignment_mask/20230719-213204
base:   git://anongit.freedesktop.org/drm/drm-tip drm-tip
patch link:    https://lore.kernel.org/r/20230719132822.305612-5-luciano.coelho%40intel.com
patch subject:  [PATCH 4/4] drm/i915/tc: remove "fia" from intel_tc_port_fia_max_lane_count()
config: x86_64-defconfig (https://download.01.org/0day-ci/archive/20230719/202307192336.hHukzc8N-lkp@xxxxxxxxx/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce: (https://download.01.org/0day-ci/archive/20230719/202307192336.hHukzc8N-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202307192336.hHukzc8N-lkp@xxxxxxxxx/

All errors (new ones prefixed by >>):

   drivers/gpu/drm/i915/display/intel_cx0_phy.c: In function 'intel_cx0_phy_lane_reset':
>> drivers/gpu/drm/i915/display/intel_cx0_phy.c:2537:28: error: implicit declaration of function 'intel_tc_port_fia_max_lane_count'; did you mean 'intel_tc_port_max_lane_count'? [-Werror=implicit-function-declaration]
    2537 |         bool both_lanes =  intel_tc_port_fia_max_lane_count(enc_to_dig_port(encoder)) > 2;
         |                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
         |                            intel_tc_port_max_lane_count
   cc1: all warnings being treated as errors


vim +2537 drivers/gpu/drm/i915/display/intel_cx0_phy.c

51390cc0e00a37 Radhakrishna Sripada 2023-04-13  2530  
619a06dba6fa38 Mika Kahola          2023-06-01  2531  static void intel_cx0_phy_lane_reset(struct drm_i915_private *i915,
619a06dba6fa38 Mika Kahola          2023-06-01  2532  				     struct intel_encoder *encoder,
51390cc0e00a37 Radhakrishna Sripada 2023-04-13  2533  				     bool lane_reversal)
51390cc0e00a37 Radhakrishna Sripada 2023-04-13  2534  {
619a06dba6fa38 Mika Kahola          2023-06-01  2535  	enum port port = encoder->port;
51390cc0e00a37 Radhakrishna Sripada 2023-04-13  2536  	enum phy phy = intel_port_to_phy(i915, port);
619a06dba6fa38 Mika Kahola          2023-06-01 @2537  	bool both_lanes =  intel_tc_port_fia_max_lane_count(enc_to_dig_port(encoder)) > 2;
51390cc0e00a37 Radhakrishna Sripada 2023-04-13  2538  	u8 lane_mask = lane_reversal ? INTEL_CX0_LANE1 :
51390cc0e00a37 Radhakrishna Sripada 2023-04-13  2539  				  INTEL_CX0_LANE0;
619a06dba6fa38 Mika Kahola          2023-06-01  2540  	u32 lane_pipe_reset = both_lanes ?
619a06dba6fa38 Mika Kahola          2023-06-01  2541  			      XELPDP_LANE_PIPE_RESET(0) |
619a06dba6fa38 Mika Kahola          2023-06-01  2542  			      XELPDP_LANE_PIPE_RESET(1) :
619a06dba6fa38 Mika Kahola          2023-06-01  2543  			      XELPDP_LANE_PIPE_RESET(0);
619a06dba6fa38 Mika Kahola          2023-06-01  2544  	u32 lane_phy_current_status = both_lanes ?
619a06dba6fa38 Mika Kahola          2023-06-01  2545  				      XELPDP_LANE_PHY_CURRENT_STATUS(0) |
619a06dba6fa38 Mika Kahola          2023-06-01  2546  				      XELPDP_LANE_PHY_CURRENT_STATUS(1) :
619a06dba6fa38 Mika Kahola          2023-06-01  2547  				      XELPDP_LANE_PHY_CURRENT_STATUS(0);
51390cc0e00a37 Radhakrishna Sripada 2023-04-13  2548  
51390cc0e00a37 Radhakrishna Sripada 2023-04-13  2549  	if (__intel_de_wait_for_register(i915, XELPDP_PORT_BUF_CTL1(port),
51390cc0e00a37 Radhakrishna Sripada 2023-04-13  2550  					 XELPDP_PORT_BUF_SOC_PHY_READY,
51390cc0e00a37 Radhakrishna Sripada 2023-04-13  2551  					 XELPDP_PORT_BUF_SOC_PHY_READY,
51390cc0e00a37 Radhakrishna Sripada 2023-04-13  2552  					 XELPDP_PORT_BUF_SOC_READY_TIMEOUT_US, 0, NULL))
51390cc0e00a37 Radhakrishna Sripada 2023-04-13  2553  		drm_warn(&i915->drm, "PHY %c failed to bring out of SOC reset after %dus.\n",
51390cc0e00a37 Radhakrishna Sripada 2023-04-13  2554  			 phy_name(phy), XELPDP_PORT_BUF_SOC_READY_TIMEOUT_US);
51390cc0e00a37 Radhakrishna Sripada 2023-04-13  2555  
51390cc0e00a37 Radhakrishna Sripada 2023-04-13  2556  	intel_de_rmw(i915, XELPDP_PORT_BUF_CTL2(port),
51390cc0e00a37 Radhakrishna Sripada 2023-04-13  2557  		     XELPDP_LANE_PIPE_RESET(0) | XELPDP_LANE_PIPE_RESET(1),
619a06dba6fa38 Mika Kahola          2023-06-01  2558  		     lane_pipe_reset);
51390cc0e00a37 Radhakrishna Sripada 2023-04-13  2559  
51390cc0e00a37 Radhakrishna Sripada 2023-04-13  2560  	if (__intel_de_wait_for_register(i915, XELPDP_PORT_BUF_CTL2(port),
619a06dba6fa38 Mika Kahola          2023-06-01  2561  					 lane_phy_current_status, lane_phy_current_status,
51390cc0e00a37 Radhakrishna Sripada 2023-04-13  2562  					 XELPDP_PORT_RESET_START_TIMEOUT_US, 0, NULL))
51390cc0e00a37 Radhakrishna Sripada 2023-04-13  2563  		drm_warn(&i915->drm, "PHY %c failed to bring out of Lane reset after %dus.\n",
51390cc0e00a37 Radhakrishna Sripada 2023-04-13  2564  			 phy_name(phy), XELPDP_PORT_RESET_START_TIMEOUT_US);
51390cc0e00a37 Radhakrishna Sripada 2023-04-13  2565  
51390cc0e00a37 Radhakrishna Sripada 2023-04-13  2566  	intel_de_rmw(i915, XELPDP_PORT_CLOCK_CTL(port),
619a06dba6fa38 Mika Kahola          2023-06-01  2567  		     intel_cx0_get_pclk_refclk_request(both_lanes ?
619a06dba6fa38 Mika Kahola          2023-06-01  2568  						       INTEL_CX0_BOTH_LANES :
619a06dba6fa38 Mika Kahola          2023-06-01  2569  						       INTEL_CX0_LANE0),
51390cc0e00a37 Radhakrishna Sripada 2023-04-13  2570  		     intel_cx0_get_pclk_refclk_request(lane_mask));
51390cc0e00a37 Radhakrishna Sripada 2023-04-13  2571  
51390cc0e00a37 Radhakrishna Sripada 2023-04-13  2572  	if (__intel_de_wait_for_register(i915, XELPDP_PORT_CLOCK_CTL(port),
619a06dba6fa38 Mika Kahola          2023-06-01  2573  					 intel_cx0_get_pclk_refclk_ack(both_lanes ?
619a06dba6fa38 Mika Kahola          2023-06-01  2574  								       INTEL_CX0_BOTH_LANES :
619a06dba6fa38 Mika Kahola          2023-06-01  2575  								       INTEL_CX0_LANE0),
51390cc0e00a37 Radhakrishna Sripada 2023-04-13  2576  					 intel_cx0_get_pclk_refclk_ack(lane_mask),
51390cc0e00a37 Radhakrishna Sripada 2023-04-13  2577  					 XELPDP_REFCLK_ENABLE_TIMEOUT_US, 0, NULL))
51390cc0e00a37 Radhakrishna Sripada 2023-04-13  2578  		drm_warn(&i915->drm, "PHY %c failed to request refclk after %dus.\n",
51390cc0e00a37 Radhakrishna Sripada 2023-04-13  2579  			 phy_name(phy), XELPDP_REFCLK_ENABLE_TIMEOUT_US);
51390cc0e00a37 Radhakrishna Sripada 2023-04-13  2580  
51390cc0e00a37 Radhakrishna Sripada 2023-04-13  2581  	intel_cx0_powerdown_change_sequence(i915, port, INTEL_CX0_BOTH_LANES,
51390cc0e00a37 Radhakrishna Sripada 2023-04-13  2582  					    CX0_P2_STATE_RESET);
51390cc0e00a37 Radhakrishna Sripada 2023-04-13  2583  	intel_cx0_setup_powerdown(i915, port);
51390cc0e00a37 Radhakrishna Sripada 2023-04-13  2584  
619a06dba6fa38 Mika Kahola          2023-06-01  2585  	intel_de_rmw(i915, XELPDP_PORT_BUF_CTL2(port), lane_pipe_reset, 0);
51390cc0e00a37 Radhakrishna Sripada 2023-04-13  2586  
619a06dba6fa38 Mika Kahola          2023-06-01  2587  	if (intel_de_wait_for_clear(i915, XELPDP_PORT_BUF_CTL2(port), lane_phy_current_status,
51390cc0e00a37 Radhakrishna Sripada 2023-04-13  2588  				    XELPDP_PORT_RESET_END_TIMEOUT))
51390cc0e00a37 Radhakrishna Sripada 2023-04-13  2589  		drm_warn(&i915->drm, "PHY %c failed to bring out of Lane reset after %dms.\n",
51390cc0e00a37 Radhakrishna Sripada 2023-04-13  2590  			 phy_name(phy), XELPDP_PORT_RESET_END_TIMEOUT);
51390cc0e00a37 Radhakrishna Sripada 2023-04-13  2591  }
51390cc0e00a37 Radhakrishna Sripada 2023-04-13  2592  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki



[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux