> -----Original Message----- > From: Intel-gfx <intel-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of intel- > gfx-request@xxxxxxxxxxxxxxxxxxxxx > Sent: Friday, July 14, 2023 7:10 PM > To: intel-gfx@xxxxxxxxxxxxxxxxxxxxx > Subject: Intel-gfx Digest, Vol 186, Issue 211 > > Send Intel-gfx mailing list submissions to > intel-gfx@xxxxxxxxxxxxxxxxxxxxx > > To subscribe or unsubscribe via the World Wide Web, visit > https://lists.freedesktop.org/mailman/listinfo/intel-gfx > or, via email, send a message with subject or body 'help' to > intel-gfx-request@xxxxxxxxxxxxxxxxxxxxx > > You can reach the person managing the list at > intel-gfx-owner@xxxxxxxxxxxxxxxxxxxxx > > When replying, please edit your Subject line so it is more specific than "Re: > Contents of Intel-gfx digest..." > > > Today's Topics: > > 1. [PATCH] drm/i915: Start using plane scale factor for relative > data rate (Stanislav Lisovskiy) > 2. Re: [PATCH v9 09/10] vfio/pci: Copy hot-reset device info to > userspace in the devices loop (Jason Gunthorpe) > 3. ? Fi.CI.BAT: success for drm/i915: Start using plane scale > factor for relative data rate (Patchwork) > > > ---------------------------------------------------------------------- > > Message: 1 > Date: Fri, 14 Jul 2023 15:34:56 +0300 > From: Stanislav Lisovskiy <stanislav.lisovskiy@xxxxxxxxx> > To: intel-gfx@xxxxxxxxxxxxxxxxxxxxx > Subject: [PATCH] drm/i915: Start using plane scale factor > for relative data rate > Message-ID: <20230714123456.19153-1-stanislav.lisovskiy@xxxxxxxxx> > > BSpec 68907 clearly instructs us to use plane scale factor when calculating > relative data rate to be used when allocating DDB blocks for each plane. > For some reason we use scale factor for data_rate calculation, which is used > for BW calculations, however we are not using it for DDB calculations. > > Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@xxxxxxxxx> Reviewed-by: Garg, Nemesa <nemesa.garg@xxxxxxxxx> > --- > drivers/gpu/drm/i915/display/intel_atomic_plane.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_atomic_plane.c > b/drivers/gpu/drm/i915/display/intel_atomic_plane.c > index 7d9578ebae556..60a492e186ab8 100644 > --- a/drivers/gpu/drm/i915/display/intel_atomic_plane.c > +++ b/drivers/gpu/drm/i915/display/intel_atomic_plane.c > @@ -212,6 +212,7 @@ intel_plane_relative_data_rate(const struct > intel_crtc_state *crtc_state, > struct intel_plane *plane = to_intel_plane(plane_state->uapi.plane); > const struct drm_framebuffer *fb = plane_state->hw.fb; > int width, height; > + unsigned int rel_data_rate; > > if (plane->id == PLANE_CURSOR) > return 0; > @@ -241,7 +242,11 @@ intel_plane_relative_data_rate(const struct > intel_crtc_state *crtc_state, > height /= 2; > } > > - return width * height * fb->format->cpp[color_plane]; > + rel_data_rate = width * height * fb->format->cpp[color_plane]; > + > + return intel_adjusted_rate(&plane_state->uapi.src, > + &plane_state->uapi.dst, > + rel_data_rate); > } > LGTM, Thanks and Regards, Nemesa > int intel_plane_calc_min_cdclk(struct intel_atomic_state *state, > -- > 2.37.3 > > > > ------------------------------ > > Message: 2 > Date: Fri, 14 Jul 2023 10:36:55 -0300 > From: Jason Gunthorpe <jgg@xxxxxxxxxx> > To: Yi Liu <yi.l.liu@xxxxxxxxx> > Cc: alex.williamson@xxxxxxxxxx, kevin.tian@xxxxxxxxx, joro@xxxxxxxxxx, > robin.murphy@xxxxxxx, cohuck@xxxxxxxxxx, > eric.auger@xxxxxxxxxx, > nicolinc@xxxxxxxxxx, kvm@xxxxxxxxxxxxxxx, > mjrosato@xxxxxxxxxxxxx, > chao.p.peng@xxxxxxxxxxxxxxx, yi.y.sun@xxxxxxxxxxxxxxx, > peterx@xxxxxxxxxx, jasowang@xxxxxxxxxx, > shameerali.kolothum.thodi@xxxxxxxxxx, lulu@xxxxxxxxxx, > suravee.suthikulpanit@xxxxxxx, intel-gvt- > dev@xxxxxxxxxxxxxxxxxxxxx, > intel-gfx@xxxxxxxxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, > xudong.hao@xxxxxxxxx, yan.y.zhao@xxxxxxxxx, > terrence.xu@xxxxxxxxx, > yanting.jiang@xxxxxxxxx, zhenzhong.duan@xxxxxxxxx, > clegoate@xxxxxxxxxx > Subject: Re: [PATCH v9 09/10] vfio/pci: Copy hot-reset > device info to userspace in the devices loop > Message-ID: <ZLFPd2coVKPcI05G@xxxxxxxxxx> > Content-Type: text/plain; charset=us-ascii > > On Mon, Jul 10, 2023 at 07:31:25PM -0700, Yi Liu wrote: > > > @@ -1311,29 +1296,17 @@ static int > vfio_pci_ioctl_get_pci_hot_reset_info( > > ret = vfio_pci_for_each_slot_or_bus(vdev->pdev, vfio_pci_fill_devs, > > &fill, slot); > > mutex_unlock(&vdev->vdev.dev_set->lock); > > + if (ret) > > + return ret; > > > > - /* > > - * If a device was removed between counting and filling, we may > come up > > - * short of fill.max. If a device was added, we'll have a return of > > - * -EAGAIN above. > > - */ > > - if (!ret) { > > - hdr.count = fill.cur; > > - hdr.flags = fill.flags; > > - } > > - > > -reset_info_exit: > > + hdr.count = fill.count; > > + hdr.flags = fill.flags; > > if (copy_to_user(arg, &hdr, minsz)) > > - ret = -EFAULT; > > - > > - if (!ret) { > > - if (copy_to_user(&arg->devices, devices, > > - hdr.count * sizeof(*devices))) > > - ret = -EFAULT; > > - } > > + return -EFAULT; > > > > - kfree(devices); > > - return ret; > > + if (fill.count != fill.devices - arg->devices) > > + return -ENOSPC; > > This should be > right? The previous code returned ENOSPC only if > their were more devices than requested, not less. > > Jason > > > ------------------------------ > > Message: 3 > Date: Fri, 14 Jul 2023 13:40:27 -0000 > From: Patchwork <patchwork@xxxxxxxxxxxxxxxxxxxxxx> > To: "Stanislav Lisovskiy" <stanislav.lisovskiy@xxxxxxxxx> > Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx > Subject: ? Fi.CI.BAT: success for drm/i915: Start using > plane scale factor for relative data rate > Message-ID: > <168934202742.13875.17191708900969933819@emeril.freedesktop. > org> > Content-Type: text/plain; charset="utf-8" > > == Series Details == > > Series: drm/i915: Start using plane scale factor for relative data rate > URL : https://patchwork.freedesktop.org/series/120767/ > State : success > > == Summary == > > CI Bug Log - changes from CI_DRM_13385 -> Patchwork_120767v1 > ==================================================== > > Summary > ------- > > **SUCCESS** > > No regressions found. > > External URL: https://intel-gfx-ci.01.org/tree/drm- > tip/Patchwork_120767v1/index.html > > Participating hosts (41 -> 43) > ------------------------------ > > Additional (3): fi-kbl-soraka bat-dg2-13 bat-dg2-14 > Missing (1): fi-snb-2520m > > Known issues > ------------ > > Here are the changes found in Patchwork_120767v1 that come from known > issues: > > ### IGT changes ### > > #### Issues hit #### > > * igt@gem_huc_copy@huc-copy: > - fi-kbl-soraka: NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#2190]) > [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120767v1/fi-kbl- > soraka/igt@gem_huc_copy@xxxxxxxxxxxxx > > * igt@gem_lmem_swapping@basic: > - fi-kbl-soraka: NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#4613]) +3 > similar issues > [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120767v1/fi-kbl- > soraka/igt@gem_lmem_swapping@xxxxxxxxxx > > * igt@i915_selftest@live@execlists: > - fi-bsw-nick: [PASS][3] -> [ABORT][4] ([i915#7911] / [i915#7913]) > [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13385/fi-bsw- > nick/igt@i915_selftest@live@xxxxxxxxxxxxxx > [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120767v1/fi-bsw- > nick/igt@i915_selftest@live@xxxxxxxxxxxxxx > > * igt@i915_selftest@live@gt_heartbeat: > - fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][5] ([i915#5334] / [i915#7872]) > [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120767v1/fi-kbl- > soraka/igt@i915_selftest@live@gt_heartbeat.html > > * igt@i915_selftest@live@gt_pm: > - fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][6] ([i915#1886] / [i915#7913]) > [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120767v1/fi-kbl- > soraka/igt@i915_selftest@live@gt_pm.html > > * igt@i915_selftest@live@slpc: > - bat-rpls-1: NOTRUN -> [DMESG-WARN][7] ([i915#6367]) > [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120767v1/bat-rpls- > 1/igt@i915_selftest@live@xxxxxxxxx > > * igt@i915_suspend@basic-s3-without-i915: > - bat-mtlp-6: NOTRUN -> [SKIP][8] ([i915#6645]) > [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120767v1/bat-mtlp- > 6/igt@i915_suspend@xxxxxxxxxxxxxxxxxxxxxxxxxx > - bat-rpls-1: NOTRUN -> [ABORT][9] ([i915#6687] / [i915#7978] / > [i915#8668]) > [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120767v1/bat-rpls- > 1/igt@i915_suspend@xxxxxxxxxxxxxxxxxxxxxxxxxx > > * igt@kms_chamelium_hpd@common-hpd-after-suspend: > - bat-mtlp-6: NOTRUN -> [SKIP][10] ([i915#7828]) > [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120767v1/bat- > mtlp-6/igt@kms_chamelium_hpd@xxxxxxxxxxxxxxxxxxxxxxxxxxxxx > - bat-dg2-11: NOTRUN -> [SKIP][11] ([i915#7828]) > [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120767v1/bat-dg2- > 11/igt@kms_chamelium_hpd@xxxxxxxxxxxxxxxxxxxxxxxxxxxxx > > * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic: > - fi-kbl-soraka: NOTRUN -> [SKIP][12] ([fdo#109271]) +15 similar issues > [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120767v1/fi-kbl- > soraka/igt@kms_cursor_legacy@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx > > * igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1: > - bat-rplp-1: [PASS][13] -> [ABORT][14] ([i915#8442] / [i915#8668]) > [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13385/bat-rplp- > 1/igt@kms_pipe_crc_basic@read-crc-frame-sequence@xxxxxxxxxxxxxxxxx > [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120767v1/bat- > rplp-1/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp- > 1.html > > * igt@kms_pipe_crc_basic@suspend-read-crc: > - bat-mtlp-6: NOTRUN -> [SKIP][15] ([i915#1845] / [i915#4078]) > [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120767v1/bat- > mtlp-6/igt@kms_pipe_crc_basic@xxxxxxxxxxxxxxxxxxxxx > > > #### Possible fixes #### > > * igt@i915_pm_rpm@basic-rte: > - fi-skl-guc: [FAIL][16] ([i915#7940]) -> [PASS][17] > [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13385/fi-skl- > guc/igt@i915_pm_rpm@xxxxxxxxxxxxxx > [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120767v1/fi-skl- > guc/igt@i915_pm_rpm@xxxxxxxxxxxxxx > > * igt@i915_selftest@live@requests: > - bat-mtlp-6: [ABORT][18] ([i915#7982]) -> [PASS][19] > [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13385/bat-mtlp- > 6/igt@i915_selftest@live@xxxxxxxxxxxxx > [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120767v1/bat- > mtlp-6/igt@i915_selftest@live@xxxxxxxxxxxxx > > * igt@i915_selftest@live@reset: > - bat-rpls-1: [ABORT][20] ([i915#4983] / [i915#7461] / [i915#8347] / > [i915#8384]) -> [PASS][21] > [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13385/bat-rpls- > 1/igt@i915_selftest@live@xxxxxxxxxx > [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120767v1/bat- > rpls-1/igt@i915_selftest@live@xxxxxxxxxx > > * igt@i915_selftest@live@slpc: > - bat-rpls-2: [DMESG-WARN][22] ([i915#6367]) -> [PASS][23] > [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13385/bat-rpls- > 2/igt@i915_selftest@live@xxxxxxxxx > [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120767v1/bat- > rpls-2/igt@i915_selftest@live@xxxxxxxxx > > * igt@i915_selftest@live@workarounds: > - bat-dg2-11: [INCOMPLETE][24] ([i915#7913]) -> [PASS][25] > [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13385/bat-dg2- > 11/igt@i915_selftest@live@xxxxxxxxxxxxxxxx > [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120767v1/bat-dg2- > 11/igt@i915_selftest@live@xxxxxxxxxxxxxxxx > > > #### Warnings #### > > * igt@core_auth@basic-auth: > - bat-adlp-11: [ABORT][26] ([i915#8011]) -> [ABORT][27] ([i915#4423] / > [i915#8011]) > [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13385/bat-adlp- > 11/igt@core_auth@xxxxxxxxxxxxxxx > [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120767v1/bat- > adlp-11/igt@core_auth@xxxxxxxxxxxxxxx > > > {name}: This element is suppressed. This means it is ignored when > computing > the status of the difference (SUCCESS, WARNING, or FAILURE). > > [Intel XE#484]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/484 > [Intel XE#486]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/486 > [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 > [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285 > [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072 > [i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845 > [i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886 > [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190 > [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555 > [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077 > [i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078 > [i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079 > [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083 > [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103 > [i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212 > [i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213 > [i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215 > [i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423 > [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613 > [i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983 > [i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190 > [i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274 > [i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334 > [i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354 > [i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367 > [i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645 > [i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687 > [i915#7359]: https://gitlab.freedesktop.org/drm/intel/issues/7359 > [i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461 > [i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561 > [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828 > [i915#7872]: https://gitlab.freedesktop.org/drm/intel/issues/7872 > [i915#7911]: https://gitlab.freedesktop.org/drm/intel/issues/7911 > [i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913 > [i915#7940]: https://gitlab.freedesktop.org/drm/intel/issues/7940 > [i915#7978]: https://gitlab.freedesktop.org/drm/intel/issues/7978 > [i915#7982]: https://gitlab.freedesktop.org/drm/intel/issues/7982 > [i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011 > [i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347 > [i915#8384]: https://gitlab.freedesktop.org/drm/intel/issues/8384 > [i915#8442]: https://gitlab.freedesktop.org/drm/intel/issues/8442 > [i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668 > > > Build changes > ------------- > > * Linux: CI_DRM_13385 -> Patchwork_120767v1 > > CI-20190529: 20190529 > CI_DRM_13385: f8be3c363790b79801f7be6bd40062219e3789bc @ > git://anongit.freedesktop.org/gfx-ci/linux > IGT_7386: 54dc25efaf10d87962f95be9b1d1a8f0f907912b @ > https://gitlab.freedesktop.org/drm/igt-gpu-tools.git > Patchwork_120767v1: f8be3c363790b79801f7be6bd40062219e3789bc @ > git://anongit.freedesktop.org/gfx-ci/linux > > > ### Linux commits > > 5bddc09c8d95 drm/i915: Start using plane scale factor for relative data rate > > == Logs == > > For more details see: https://intel-gfx-ci.01.org/tree/drm- > tip/Patchwork_120767v1/index.html > -------------- next part -------------- > An HTML attachment was scrubbed... > URL: <https://lists.freedesktop.org/archives/intel- > gfx/attachments/20230714/28e943d6/attachment.htm> > > ------------------------------ > > Subject: Digest Footer > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/intel-gfx > > > ------------------------------ > > End of Intel-gfx Digest, Vol 186, Issue 211 > *******************************************
