> From: Jason Gunthorpe <jgg@xxxxxxxxxx> > Sent: Saturday, July 15, 2023 9:05 PM > > On Sat, Jul 15, 2023 at 04:16:52AM +0000, Liu, Yi L wrote: > > > From: Jason Gunthorpe <jgg@xxxxxxxxxx> > > > Sent: Friday, July 14, 2023 10:42 PM > > > > > > On Mon, Jul 10, 2023 at 07:59:24PM -0700, Yi Liu wrote: > > > > > > > +static inline long vfio_df_ioctl_bind_iommufd(struct vfio_device_file *df, > > > > + struct vfio_device_bind_iommufd __user > > > *arg) > > > > +{ > > > > + return -EOPNOTSUPP; > > > > +} > > > > > > This should be -ENOTTY > > > > Okay. Since there are quite a few stub functions in the drivers/vfio/vfio.h. > > Let me check the rule. All the stub functions should return -ENOTTY in > > the !IS_ENABLED(CONFIG_XXX) case, if the function returns int., is > > it? > > No, just ioctl returns ENOTTY, so really just this function. Ok. I see. Regards, Yi Liu