On 11/07/2023 12:02, Jani Nikula wrote:
This reverts commit 88e9664434c994e97a9f6f8cdd1535495c660cea.
__diag_ignore_all() only works for GCC 8 or later.
-Woverride-init (from -Wextra, enabled in i915 Makefile) combined with
CONFIG_WERROR=y or W=e breaks the build for older GCC.
With i386_defconfig and x86_64_defconfig enabling CONFIG_WERROR=y by
default, we really need to roll back the change.
An alternative would be to disable -Woverride-init in the Makefile for
GCC <8, but the revert seems like the safest bet now.
Closes:https://urldefense.com/v3/__https://gitlab.freedesktop.org/drm/intel/-/issues/8768__;!!ACWV5N9M2RV99hQ!IHKvxwtPYBXBj_pfrXmPg5H_6OVsPZaDRDgUUuYsj2IY_JpxM3APirbZR_0yg5UO61Gf2d79Ud7fgySHuVwhOPo$
Reported-by: John Garry<john.g.garry@xxxxxxxxxx>
References:https://urldefense.com/v3/__https://lore.kernel.org/r/ad2601c0-84bb-c574-3702-a83ff8faf98c@oracle.com__;!!ACWV5N9M2RV99hQ!IHKvxwtPYBXBj_pfrXmPg5H_6OVsPZaDRDgUUuYsj2IY_JpxM3APirbZR_0yg5UO61Gf2d79Ud7fgySH0A7kxf4$
References:https://urldefense.com/v3/__https://lore.kernel.org/r/87wmzezns4.fsf@intel.com__;!!ACWV5N9M2RV99hQ!IHKvxwtPYBXBj_pfrXmPg5H_6OVsPZaDRDgUUuYsj2IY_JpxM3APirbZR_0yg5UO61Gf2d79Ud7fgySHAwJkTDk$
Fixes: 88e9664434c9 ("drm/i915: use localized __diag_ignore_all() instead of per file")
Cc: Gustavo Sousa<gustavo.sousa@xxxxxxxxx>
Cc: Joonas Lahtinen<joonas.lahtinen@xxxxxxxxxxxxxxx>
Cc: Rodrigo Vivi<rodrigo.vivi@xxxxxxxxx>
Cc: Tvrtko Ursulin<tvrtko.ursulin@xxxxxxxxxxxxxxx>
Signed-off-by: Jani Nikula<jani.nikula@xxxxxxxxx>
I tested on next-20230711, as this does not apply to v6.5-rc1 (where I
originally experienced the issue):
Tested-by: John Garry <john.g.garry@xxxxxxxxxx>
cheers
