> On Mon, 10 Jul 2023, Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx> wrote:
> > On Mon, 10 Jul 2023, Suraj Kandpal <suraj.kandpal@xxxxxxxxx> wrote:
> >> Add PPS enum so that we can later on use it to distinguish which PPS
> >> is being read or written onto.
> >
> > The patch adding the enum alone isn't useful, should be squashed with
> > something that uses it.
>
> Also, maybe you could just use an int?
>
I see will drop this patch and use int instead
Regards,
Suraj Kandpal
> >
> > BR,
> > Jani.
> >
> >>
> >> Signed-off-by: Suraj Kandpal <suraj.kandpal@xxxxxxxxx>
> >> ---
> >> drivers/gpu/drm/i915/display/intel_vdsc.c | 17 +++++++++++++++++
> >> 1 file changed, 17 insertions(+)
> >>
> >> diff --git a/drivers/gpu/drm/i915/display/intel_vdsc.c
> >> b/drivers/gpu/drm/i915/display/intel_vdsc.c
> >> index bd9116d2cd76..1a8272324c36 100644
> >> --- a/drivers/gpu/drm/i915/display/intel_vdsc.c
> >> +++ b/drivers/gpu/drm/i915/display/intel_vdsc.c
> >> @@ -19,6 +19,23 @@
> >> #include "intel_vdsc.h"
> >> #include "intel_vdsc_regs.h"
> >>
> >> +enum intel_dsc_pps {
> >> + PPS_0 = 0,
> >> + PPS_1,
> >> + PPS_2,
> >> + PPS_3,
> >> + PPS_4,
> >> + PPS_5,
> >> + PPS_6,
> >> + PPS_7,
> >> + PPS_8,
> >> + PPS_9,
> >> + PPS_10,
> >> + PPS_16,
> >> + PPS_17,
> >> + PPS_18,
> >> +};
> >> +
> >> bool intel_dsc_source_support(const struct intel_crtc_state
> >> *crtc_state) {
> >> const struct intel_crtc *crtc =
> >> to_intel_crtc(crtc_state->uapi.crtc);
>
> --
> Jani Nikula, Intel Open Source Graphics Center
