On Wed, 05 Jul 2023, Ville Syrjala <ville.syrjala@xxxxxxxxxxxxxxx> wrote: > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > I have plans to switch the whole driver over to using > drm_connector_init_with_ddc(), and thus populate the > sysfs "ddc" consistently. The biggest hurdle is the > SDVO DDC handling, so start by cleaning that up. I support the goal of moving towards drm_connector_init_with_ddc(), and after that, to drm_edid_read() where applicable. I admit to being a notch less diligent in reviewing all the details of legacy encoder code, but there are no obvious mistakes here that I could spot, and overall it makes sense. Thanks, Jani. > > I also found some other issues with the SDVO code so > some additional fixes are also included. > > Ville Syrjälä (13): > drm/i915/sdvo: Issue SetTargetOutput prior ot GetAttachedDisplays > drm/i915/sdvo: Protect macro args > drm/i915/sdvo: s/sdvo_inputs_mask/sdvo_num_inputs/ > drm/i915: Don't warn about zero N/P in *_calc_dpll_params() > drm/i915: Fully populate crtc_state->dpll > drm/i915/sdvo: Pick the TV dotclock from adjusted_mode > drm/i915/sdvo: Fail gracefully if the TV dotclock is out of range > drm/i915/sdvo: Nuke attached_output tracking > drm/i915/sdvo: Initialize the encoder ealier > drm/i915/sdvo: Nuke the duplicate sdvo->port > drm/i915/sdvo: Get rid of the per-connector i2c symlink > drm/i915/sdvo: Rework DDC bus handling > drm/i915/sdvo: Print out the i2c pin and slave address > > drivers/gpu/drm/i915/display/intel_dpll.c | 54 ++- > drivers/gpu/drm/i915/display/intel_sdvo.c | 357 +++++++++--------- > .../gpu/drm/i915/display/intel_sdvo_regs.h | 2 +- > 3 files changed, 219 insertions(+), 194 deletions(-) -- Jani Nikula, Intel Open Source Graphics Center
