Hello Jani,
> -----Original Message-----
> From: Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx>
> Sent: Monday, June 26, 2023 12:25 PM
> To: Borah, Chaitanya Kumar <chaitanya.kumar.borah@xxxxxxxxx>; intel-
> gfx@xxxxxxxxxxxxxxxxxxxxx
> Cc: Shankar, Uma <uma.shankar@xxxxxxxxx>; Murthy, Arun R
> <arun.r.murthy@xxxxxxxxx>; Borah, Chaitanya Kumar
> <chaitanya.kumar.borah@xxxxxxxxx>
> Subject: Re: [PATCH] drm/i915/display: Add header file for struct seq_file
>
> On Mon, 26 Jun 2023, Chaitanya Kumar Borah
> <chaitanya.kumar.borah@xxxxxxxxx> wrote:
> > With change [1], visibility of struct seq_file is lost in
> > intel_display_power.h leading to build errors. Add header file
> > explicitly to restore visibility.
> >
> > [1] ef104443bffa ("procfs: consolidate arch_report_meminfo
> > declaration")
> >
> > Signed-off-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@xxxxxxxxx>
> > ---
> > drivers/gpu/drm/i915/display/intel_display_power.h | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_display_power.h
> > b/drivers/gpu/drm/i915/display/intel_display_power.h
> > index be1a87bde0c9..888993079a7b 100644
> > --- a/drivers/gpu/drm/i915/display/intel_display_power.h
> > +++ b/drivers/gpu/drm/i915/display/intel_display_power.h
> > @@ -6,6 +6,8 @@
> > #ifndef __INTEL_DISPLAY_POWER_H__
> > #define __INTEL_DISPLAY_POWER_H__
> >
> > +#include <linux/seq_file.h>
> > +
>
> Always prefer a forward declaration over an include when it's sufficient.
>
Thank you for your comment, I have sent out the v2 of the patch with forward declaration.
Is there a path for this patch to get merged into linux-next?
Regards
Chaitanya
> BR,
> Jani.
>
>
> > #include "intel_wakeref.h"
> >
> > enum aux_ch;
>
> --
> Jani Nikula, Intel Open Source Graphics Center
