Re: [PATCH v2] drm/i915/hdcp: Add a debug statment at hdcp2 capability check

[Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx>]

On Wed, 21 Jun 2023, Suraj Kandpal <suraj.kandpal@xxxxxxxxx> wrote:
> Add a debug statement at hdcp2 capability check which indicates if
> GSC CS is causing hdcp2 incapability
>
> --v2
> -correcting typo in commit header

Maybe fix the other typo as well? ;)

BR,
Jani.

>
> Signed-off-by: Suraj Kandpal <suraj.kandpal@xxxxxxxxx>
> ---
>  drivers/gpu/drm/i915/display/intel_hdcp.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display/intel_hdcp.c
> index 5ed450111f77..73fe84fc9bf5 100644
> --- a/drivers/gpu/drm/i915/display/intel_hdcp.c
> +++ b/drivers/gpu/drm/i915/display/intel_hdcp.c
> @@ -177,8 +177,11 @@ bool intel_hdcp2_capable(struct intel_connector *connector)
>  		struct intel_gt *gt = i915->media_gt;
>  		struct intel_gsc_uc *gsc = gt ? &gt->uc.gsc : NULL;
>  
> -		if (!gsc || !intel_uc_fw_is_running(&gsc->fw))
> +		if (!gsc || !intel_uc_fw_is_running(&gsc->fw)) {
> +			drm_dbg_kms(&i915->drm,
> +				    "GSC components required for HDCP2.2 are not ready\n");
>  			return false;
> +		}
>  	}
>  
>  	/* MEI/GSC interface is solid depending on which is used */

-- 
Jani Nikula, Intel Open Source Graphics Center